Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove Ambassador's twitter link without a Twitter Account #3828

Open
2 tasks done
Recxsmacx opened this issue Mar 7, 2025 · 5 comments · May be fixed by #3859
Open
2 tasks done

[BUG] Remove Ambassador's twitter link without a Twitter Account #3828

Recxsmacx opened this issue Mar 7, 2025 · 5 comments · May be fixed by #3859
Labels

Comments

@Recxsmacx
Copy link

Describe the bug.

One of the ambassadors listed on the website does not have a Twitter account. This could be misleading for visitors.

Expected behavior

I thin removing it will be good because there is not need

Screenshots

20250307-1235-09.3629511.mp4

How to Reproduce

  1. Go to the Twitter ambassadors section on the website.
    2.Observe that one of the listed ambassadors does not have a linked Twitter account.

🥦 Browser

Brave

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@Recxsmacx Recxsmacx added the bug label Mar 7, 2025
@Recxsmacx Recxsmacx changed the title [BUG] Remove Twitter Ambassador without a Twitter Account [BUG] Remove Ambassador without a Twitter Account Mar 7, 2025
@Recxsmacx Recxsmacx changed the title [BUG] Remove Ambassador without a Twitter Account [BUG] Remove Ambassador's twitter link without a Twitter Account Mar 7, 2025
@priyanshuxkumar
Copy link
Contributor

can i work on this ?

@anshgoyalevil
Copy link
Member

Go ahead and raise a PR @Recxsmacx

@Recxsmacx
Copy link
Author

@anshgoyalevil I'm done with this issue but already three prs are going to be reviewed once they get merged i'll instantly raise for this !

@r120dhiman
Copy link

@derberg Please assign this issue to me. I would like to work on this issue.

Recxsmacx added a commit to Recxsmacx/website that referenced this issue Mar 10, 2025
Fixes asyncapi#3828

Remove the Twitter link for the ambassador without a Twitter account.

* Update `config/AMBASSADORS_MEMBERS.json` to remove the `twitter` field for the ambassador without a Twitter account.
* Modify `pages/community/ambassadors/index.tsx` to add a conditional check to only generate a Twitter URL if the ambassador has a Twitter account.
* Update `pages/community/ambassadors/index.tsx` to add a conditional check to only display the Twitter link if the profile has a Twitter account.
@SURAJ-RATHI
Copy link

SURAJ-RATHI commented Mar 10, 2025

@anshgoyalevil @Recxsmacx
i had solved this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants