-
Notifications
You must be signed in to change notification settings - Fork 132
Mixed use of ofetch and $fetch #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
$fetch = ofetch TLDR from the link;
If this answers your questions, feel free to close the issue. |
I knew that $fetch is at least some wrapper over ofetch. However, if there is no difference, I would reason that only one of the two should be used consistently throughout the codebase |
I am happy to move everything to Anyone happy to open a PR for this? 🙏 |
While reading the codebase (to potentially implement #89, most likely based on the existing Keycloak provider) I noticed that some places use ofetch and others use $fetch. Is there a specific reason for this? Otherwise it might be wise to unify them and use one of the two consistently throughout the codebase.
The text was updated successfully, but these errors were encountered: