You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root Cause: On Windows, os.path.join() combined a Unix-style destination path (with forward slashes) with filenames, resulting in mixed path separators (e.g., ./local/tmp/artifacts/.../count_models\chunk-0-part0.json) which caused "file not found" errors.
Solution: pathlib.Path automatically handles OS-specific path separators, ensuring correct file paths on all operating systems.
Checklist
Additional tests added
All CI checks passed
Relevant documentation updated
Copyleft License Compliance
Have you used any code that is subject to a Copyleft license (e.g., GPL, AGPL, LGPL)?
If yes, have you modified the code in the context of this project? please share additional details.
Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch. Learn more about Cursor Agents
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
ObjectStore.download_prefix()by migrating topathlib.Pathfor robust, cross-platform path handling.Additional context (e.g. screenshots, logs, links)
os.path.join()combined a Unix-styledestinationpath (with forward slashes) with filenames, resulting in mixed path separators (e.g.,./local/tmp/artifacts/.../count_models\chunk-0-part0.json) which caused "file not found" errors.pathlib.Pathautomatically handles OS-specific path separators, ensuring correct file paths on all operating systems.Checklist
Copyleft License Compliance
Slack Thread