Fix bug with environment ID being ref #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7-beta.1
🦋 Changeset detectedLatest commit: 7b05ba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yamadapc
commented
Jun 30, 2025
| asset.env.id = getFeatureFlag('environmentDeduplication') | ||
| ? // TODO: Rust can do this and avoid copying a significant amount of data over | ||
| getEnvironmentHash(asset.env) | ||
| : getEnvId(asset.env); |
Contributor
Author
There was a problem hiding this comment.
This is a number which is wrong
pancaspe87
reviewed
Jun 30, 2025
| let idAndContext = `${id}-${context}`; | ||
|
|
||
| let env = this.envCache.get(idAndContext); | ||
| if (env) { |
Contributor
There was a problem hiding this comment.
Are these changes behind a flag?
Contributor
Author
There was a problem hiding this comment.
Yes there is a flag in that function
Contributor
Author
|
This is the rust change - #201 |
pancaspe87
approved these changes
Jun 30, 2025
marcins
approved these changes
Jun 30, 2025
mattcompiles
approved these changes
Jul 1, 2025
Created using spr 1.3.7-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the flag enabled
A subsequent change will modify rust asset graph so it doesn't copy
environments over. We expect a non-negligible performance improvement to native
builds from that change.
Test Plan: N/A