Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dest not being used? #7

Open
wilr opened this issue Jul 11, 2023 · 1 comment · May be fixed by #4
Open

dest not being used? #7

wilr opened this issue Jul 11, 2023 · 1 comment · May be fixed by #4
Labels
bug Something isn't working

Comments

@wilr
Copy link

wilr commented Jul 11, 2023

I noticed assets folder is hardcoded within index.ts#L86, I would have thought that this needed to honor the dest option? At this moment there doesn't seem to be a way

const emitted = processedOptions.types.map<[T, string]>(type => [
                    type,
                    `/${this.getFileName(this.emitFile({ type: 'asset', fileName: `${processedOptions.dest}${processedOptions.fontName}-${guid()}.${type}`, source: generatedFonts?.[type] }))}`,
                ]);
@atlowChemi atlowChemi added the bug Something isn't working label Jul 11, 2023
@atlowChemi atlowChemi linked a pull request Jul 11, 2023 that will close this issue
Allow customizing the fontFace URL for production environment through cssFontsUrl. #4
Open
@atlowChemi
Copy link
Owner

atlowChemi commented Jul 11, 2023 •
edited
Loading

Hi @wilr, it seems you are correct 👍🏽

@kakigakki has opened a PR to handle this (#4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@wilr @atlowChemi