Improper folding in outline view

[mjrodgers]

I'm having some issues with the folding of functions/symbols in the outline view.

This appears to be triggered when I have lines of code that are too long and split into multiple lines. Variables that appear after this in a function do not get folded into the function in the outline view, and are instead given a new line.

[SKalt]

I'm able to reproduce this with any list comprehension within a function. Here's a minimal example:

def foo(): return [i for i in 'bar']
# the outline shows 
# lambda foo
# var i

This looks like an upstream issue with pyls, since I'm getting

"[
  {
    "name": "foo",
    "containerName": null,
    "location": {... },
    "kind": 12
  },
  {
    "name": "i",
    "containerName": null,
    "location": {...},
    "kind": 13
  }
]"

with the message

Python (pyls) rpc.sendRequest textDocument/documentSymbol received (17ms)

I wonder if VSCode has this problem as well.

[jkroes]

Confirmed that variables created within a function-level comprehension are not properly nested within the outline view.

[lgeiger]

This needs some work on the language server: palantir/python-language-server#407