Test add. Rule works.

Author: Artefall

Diff for: package.json

@@ -34,6 +34,7 @@
     "package.json"
   ],
   "dependencies": {
+    "array-flatten": "^2.1.2",
     "ramda": "^0.26.1",
     "requireindex": "^1.2.0",
     "split-camelcase": "^1.0.1"

Diff for: src/rules/no-generic-verbs.js

@@ -3,31 +3,39 @@ let utils = require('../utils');
 module.exports = {
 	meta: {
 		type: 'problem',
+		docs: {
+			url: 'https://github.com/atomspace/eslint-plugin-naming-convention/blob/master/docs/rules/no-generic-verbs.md'
+		},
 		messages: {
-			errorMessage: `The identifier has generic verb: {{ genericVerb }}.`
+			errorMessage: `The identifier has generic verb: {{ genericVerbInVariable }}.`
 		}
 	},
-	create(context) {
+	create (context) {
 		return {
-			Identifier(node) {
-				const GENERIC_VERBS = ['get', 'set', 'array', 'check', 'validate', 'make', 'process', 'start'];
+			Identifier (node) {
+				const GENERIC_VERBS = ['set', 'get', 'array', 'check', 'validate', 'make', 'process', 'start'];
 				let variableName = node.name;
 
-				let splitedVariableName = utils.splitWord(variableName);
+				let splitedVariableName = utils.splitVariable(variableName);
 
-				splitedVariableName.forEach(word => {
-					if (GENERIC_VERBS.includes(word)){
-						context.report({
-							node: node,
-							messageId: 'errorMessage',
-							data: {
-								genericVerb: word
-							}
-						});
+				let genericVerbInVariable;
+
+				for (let word of splitedVariableName) {
+					if (GENERIC_VERBS.includes(word)) {
+						genericVerbInVariable = word;
+						break;
 					}
-				});
+				}
 
+				if (!genericVerbInVariable) return;
 
+				context.report({
+					node,
+					messageId: 'errorMessage',
+					data:{
+						genericVerbInVariable
+					}
+				});
 			}
 		};
 	}

Diff for: src/utils.js

@@ -1,5 +1,9 @@
+let flat = require('array-flatten');
+
 function split (separator, string) {
-	return string.split(separator);
+	let result = string.split(separator);
+
+	return result;
 }
 
 function splitCamelCase (string) {
@@ -8,30 +12,28 @@ function splitCamelCase (string) {
 	return split(CAMEL_CASE_REGEXP, string);
 }
 
+
 function splitSnakeCase (string) {
 	const SNAKE_CASE_SEPARATOR = '_';
 
 	return split(SNAKE_CASE_SEPARATOR, string);
 }
 
-function splitKebabCase (string) {
-	const KEBAB_CASE_SEPARATOR = '-';
-
-	return split(KEBAB_CASE_SEPARATOR, string);
-}
-
 function toLowerCase (string) {
-	return string.toLowerCase();
+	if (typeof string === 'string') return string.toLowerCase();
+	return string;
 }
 
 module.exports = {
-	splitWord: word => {
-		let splitedWithCamelCase = splitCamelCase(word);
-
-		console.log(splitedWithCamelCase);
-		return splitedWithCamelCase
-			// .map(splitSnakeCase)
-			.map(splitKebabCase)
-			.map(toLowerCase);
+	splitVariable: word => {
+		let splitedWithSnakeCase = splitSnakeCase(word);
+
+		let splitedWithCamelCase = splitedWithSnakeCase.map(splitCamelCase);
+
+		let flatted = flat(splitedWithCamelCase);
+
+		let lowerCaseWords = flatted.map(toLowerCase);
+
+		return lowerCaseWords;
 	}
 };

Diff for: test/no-generic-verbs.test.js

@@ -10,6 +10,7 @@ Object.assign(ruleTester.testerConfig, {
 		ecmaVersion: 2018
 	}
 });
+
 ruleTester.run('no-generic-verb', noGenericVerbs, {
 	valid: [
 		{
@@ -43,13 +44,17 @@ ruleTester.run('no-generic-verb', noGenericVerbs, {
 			errors: [{ messageId: 'errorMessage' }]
 		},
 		{
-			code: `function validataPassword(password){
+			code: `function validatePassword(password){
 				return password === 'cucumber'
 			}`,
 			errors: [{ messageId: 'errorMessage' }]
 		},
 		{
-			code: `let simpleArray = [4,5,3]`,
+			code: `let set_variable_balue = 5`,
+			errors: [{ messageId: 'errorMessage' }]
+		},
+		{
+			code: `let set_object_value = () => 6`,
 			errors: [{ messageId: 'errorMessage' }]
 		},
 		{