fix: open session from deployments page on manual run (#1399)

## Description
When executing a manual run from the deployments page, the "Show More"
button in the success toast was attempting to navigate to a session URL
that included a deployment ID, but this navigation was failing when the
session wasn't associated with a specific deployment.

## What type of PR is this? (check all applicable)

- [ ] 💡 (feat) - A new feature (non-breaking change which adds
functionality)
- [ ] 🔄 (refactor) - Code Refactoring - A code change that neither fixes
a bug nor adds a feature
- [x] 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
- [ ] 🏎 (perf) - Optimization
- [ ] 📄 (docs) - Documentation - Documentation only changes
- [ ] 📄 (test) - Tests - Adding missing tests or correcting existing
tests
- [ ] ⚙️ (ci) - Continuous Integrations - Changes to our CI
configuration files and scripts (example scopes: Travis, Circle,
BrowserStack, SauceLabs)
- [ ] ☑️ (chore) - Chores - Other changes that don't modify src or test
files
- [ ] ↩️ (revert) - Reverts - Reverts a previous commit(s).

<!--
     For a timely review/response, please avoid force-pushing additional
     commits if your PR already received reviews or comments.
Before submitting a Pull Request, please ensure you've done the
following:
     - 👷‍♀️ Create small PRs. In most cases this will be possible.
     - ✅ Provide tests for your changes.
     - 📝 Use descriptive commit messages (as described below).
- 📗 Update any related documentation and include any relevant
screenshots.
     Commit Message Structure (all lower-case):
     <type>(optional ticket number): <description>
     [optional body]
-->

Author: RonenMars

src/components/organisms/topbar/project/manualRun/manualRunButtons.tsx

@@ -18,6 +18,7 @@ import { GearIcon, RunIcon } from "@assets/image/icons";
 
 export const ManualRunButtons = () => {
 	const { t } = useTranslation("deployments", { keyPrefix: "history" });
+	const { t: tGenericError } = useTranslation("global");
 	const { projectId } = useParams();
 	const addToast = useToastStore((state) => state.addToast);
 	const { openDrawer } = useDrawerStore();
@@ -27,13 +28,13 @@ export const ManualRunButtons = () => {
 		activeDeploymentStore,
 		entrypointFunction,
 		isManualRunEnabled,
-		saveProjectManualRun,
+		saveAndExecuteManualRun,
 		fetchManualRunConfiguration,
 	} = useManualRunStore((state) => ({
 		activeDeploymentStore: state.projectManualRun[projectId!]?.activeDeployment,
 		entrypointFunction: state.projectManualRun[projectId!]?.entrypointFunction,
 		isManualRunEnabled: state.projectManualRun[projectId!]?.isManualRunEnabled,
-		saveProjectManualRun: state.saveAndExecuteManualRun,
+		saveAndExecuteManualRun: state.saveAndExecuteManualRun,
 		fetchManualRunConfiguration: state.fetchManualRunConfiguration,
 	}));
 
@@ -52,7 +53,7 @@ export const ManualRunButtons = () => {
 		if (!projectId) return;
 		try {
 			setActionInProcess(ProjectActions.manualRun, true);
-			const { data: sessionId, error } = await saveProjectManualRun(projectId);
+			const { data: sessionId, error } = await saveAndExecuteManualRun(projectId);
 			if (error) {
 				addToast({
 					message: t("manualRun.executionFailed"),
@@ -65,6 +66,27 @@ export const ManualRunButtons = () => {
 
 				return;
 			}
+
+			if (sessionId) {
+				UserTrackingUtils.trackEvent("manual_run_executed", {
+					sessionId,
+					projectId,
+					deploymentId: activeDeploymentStore?.deploymentId,
+					entrypoint: entrypointFunction?.value,
+				});
+			} else {
+				addToast({
+					message: t("manualRun.executionFailed"),
+					type: "error",
+				});
+				LoggerService.error(
+					namespaces.ui.manualRun,
+					t("manualRun.executionFailedExtended", { projectId, error: tGenericError("genericError") })
+				);
+
+				return;
+			}
+
 			addToast({
 				message: (
 					<ManualRunSuccessToastMessage
@@ -76,15 +98,6 @@ export const ManualRunButtons = () => {
 				type: "success",
 			});
 
-			if (sessionId) {
-				UserTrackingUtils.trackEvent("manual_run_executed", {
-					sessionId,
-					projectId,
-					deploymentId: activeDeploymentStore?.deploymentId,
-					entrypoint: entrypointFunction?.value,
-				});
-			}
-
 			setTimeout(() => {
 				fetchDeployments(projectId, true);
 			}, 100);

src/components/organisms/topbar/project/manualRun/manualRunSettingsDrawer.tsx

@@ -9,6 +9,7 @@ import { namespaces } from "@src/constants";
 import { DrawerName } from "@src/enums/components";
 import { SelectOption } from "@src/interfaces/components";
 import { useCacheStore, useDrawerStore, useManualRunStore, useToastStore } from "@src/store";
+import { UserTrackingUtils } from "@src/utilities";
 import { validateManualRun } from "@validations";
 
 import { Button, IconSvg, Spinner, Typography } from "@components/atoms";
@@ -29,6 +30,7 @@ export const ManualRunSettingsDrawer = () => {
 	const { projectId } = useParams();
 	const [sendingManualRun, setSendingManualRun] = useState(false);
 	const [isValid, setIsValid] = useState(false);
+	const { t: tGenericError } = useTranslation("global");
 
 	const { projectManualRun, saveAndExecuteManualRun, updateManualRunConfiguration } = useManualRunStore((state) => ({
 		projectManualRun: state.projectManualRun[projectId!],
@@ -71,6 +73,26 @@ export const ManualRunSettingsDrawer = () => {
 			return;
 		}
 
+		if (sessionId) {
+			UserTrackingUtils.trackEvent("manual_run_executed", {
+				sessionId,
+				projectId,
+				deploymentId: activeDeployment?.deploymentId,
+				entrypoint: entrypointFunction?.value,
+			});
+		} else {
+			addToast({
+				message: t("executionFailed"),
+				type: "error",
+			});
+			LoggerService.error(
+				namespaces.ui.manualRun,
+				t("executionFailedExtended", { projectId, error: tGenericError("genericError") })
+			);
+
+			return;
+		}
+
 		addToast({
 			message: (
 				<ManualRunSuccessToastMessage

src/components/organisms/topbar/project/manualRun/manualRunSuccessToastMessage.tsx

@@ -16,16 +16,19 @@ export const ManualRunSuccessToastMessage = ({
 	projectId?: string;
 	sessionId?: string;
 }) => {
-	const { t } = useTranslation("deployments", { keyPrefix: "history.manualRun" });
+	const { t } = useTranslation("deployments", {
+		keyPrefix: "history.manualRun",
+	});
 	const navigate = useNavigate();
+	const goToSession = () =>
+		deploymentId
+			? navigate(`/projects/${projectId}/deployments/${deploymentId}/sessions/${sessionId}`)
+			: navigate(`/projects/${projectId}/sessions/${sessionId}`);
 
 	return (
 		<>
 			{t("executionSucceed")}
-			<Button
-				className="flex cursor-pointer items-center gap-1 p-0 text-green-800"
-				onClick={() => navigate(`/projects/${projectId}/deployments/${deploymentId}/sessions/${sessionId}`)}
-			>
+			<Button className="flex cursor-pointer items-center gap-1 p-0 text-green-800" onClick={goToSession}>
 				{t("showMore")}
 				<ExternalLinkIcon className="size-3.5 fill-green-800 duration-200" />
 			</Button>

src/locales/en/global/translation.json

@@ -3,6 +3,7 @@
 	"copyFailure": "Could not copy",
 	"copySuccess": "Copied to clipboard successfully",
 	"copy": "Copy",
+	"genericError": "Something went wrong, please try again later",
 	"pageTitles": {
 		"base": "AutoKitteh",
 		"template": "AutoKitteh - {{page}}",