Merge branch 'master' into txt-files-fidelity-stopping-crit

Author: Sohambasu07

neps/optimizers/utils/brackets.py

@@ -422,20 +422,24 @@ def __post_init__(self) -> None:
     def next(self) -> BracketAction:
         # Starting from the highest rung going down, check if any configs to promote
         for lower, upper in reversed(list(pairwise(self.rungs))):
-            k = len(lower) // self.eta
-            if k == 0:
-                continue  # Not enough configs to promote yet
+            import copy
 
-            if self.is_multi_objective:
-                best_k = lower.mo_selector(selector=self.mo_selector, k=k)
-            else:
-                best_k = lower.top_k(k)
-            candidates = best_k.drop(
+            lower_dropped = copy.deepcopy(lower)
+            lower_dropped.table = lower_dropped.table.drop(
                 upper.config_ids,
                 axis="index",
                 level="id",
                 errors="ignore",
             )
+            k = len(lower_dropped) // self.eta
+            if k == 0:
+                continue  # Not enough configs to promote yet
+
+            if self.is_multi_objective:
+                best_k = lower_dropped.mo_selector(selector=self.mo_selector, k=k)
+            else:
+                best_k = lower_dropped.top_k(k)
+            candidates = best_k.copy(deep=True)
             if candidates.empty:
                 continue  # No configs that aren't already promoted
 
@@ -616,11 +620,11 @@ def priority(x: BracketAction) -> tuple[int, int]:
                 case PromoteAction(new_rung=new_rung):
                     return 0, new_rung
                 case SampleAction(sample_at_rung):
-                    return 0, sample_at_rung
+                    return 1, sample_at_rung
                 case "pending":
-                    return 1, 0
-                case "done":
                     return 2, 0
+                case "done":
+                    return 3, 0
                 case _:
                     raise RuntimeError("This is a bug!")
 

neps/space/domain.py

@@ -282,14 +282,10 @@ def from_unit(self, x: Tensor, *, dtype: torch.dtype | None = None) -> Tensor:
             x = torch.round(x)
 
         if (x > upper).any():
-            import warnings
-
-            warnings.warn(  # noqa: B028
-                "Decoded value is above the upper bound of the domain. "
-                "Clipping to the upper bound. "
-                "This is likely due floating point precision in `torch.exp(x)` "
-                "with torch.float64."
-            )
+            # Decoded value is above the upper bound of the domain.
+            # Clipping to the upper bound.
+            # This is likely due floating point precision in `torch.exp(x)`
+            # with torch.float64.
             x = torch.clip(x, max=self.upper)
 
         return x.type(dtype)