Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): theme script does not detect windows terminal #9

Open
1 task done
rymancl opened this issue Dec 3, 2021 · 0 comments
Open
1 task done

fix(shell): theme script does not detect windows terminal #9

rymancl opened this issue Dec 3, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rymancl
Copy link

rymancl commented Dec 3, 2021

Commands to Reproduce

theme

Expected Results

Theme is set properly

Actual Results

Theme is not set. Adding profile manually to terminal settings.json results in an error popup.

>Found a profile with an invalid "colorScheme". Defaulting that profile to the default colors. Make sure that when setting a "colorScheme", the value matches the "name" of a color scheme in the "schemes" list.

image

Any additional logs that will help us?

Windows Terminal isn't a detected option: https://github.com/automotiveMastermind/numonic/blob/92df4d99ec8ac66edc691458fe189a411d13c627/src/sh/scripts/theme#L51-L69

Operating System(s)

Windows (WSL)

Operating System (Other)

No response

Architecture

amd64 / x86_64

Shell

bash

Terminal Program(s)

other

Terminal Program(s) (Other)

Windows Terminal (wsl)

What is the output from uname -srv on the system(s) where the bug is occurring?

Linux 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020

Code of Conduct

  • I agree to follow this project's code of conduct
@rymancl rymancl added bug Something isn't working needs triage Issue needs to be reviewed labels Dec 3, 2021
@dmccaffery dmccaffery removed the needs triage Issue needs to be reviewed label Dec 4, 2021
@dmccaffery dmccaffery self-assigned this Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants