Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: security keys -- how do we want to support them? #65

Open
dmccaffery opened this issue Nov 20, 2020 · 7 comments
Open

macOS: security keys -- how do we want to support them? #65

dmccaffery opened this issue Nov 20, 2020 · 7 comments
Labels

Comments

@dmccaffery
Copy link
Member

The macOS ssh-agent does not support security key algorithms (ed25519-sk and ecdsa-sk) out of the box. We currently support yubikeys by configuring the PGP module within the ssh-agent, but this requires the use of the aging rsa algorithm.

We have a few options:

  1. keep it the way it is for now and hope that macOS adds future support for sk algos
  2. We could support yubikeys via fido by disabling the default ssh-agent and replacing it with OpenSSH > 8.2, which has native support for sk algos -- this would bring macOS in line with our linux counterparts

I'd like to know what others think. Is anyone else using security keys besides me?

@patrickserrano
Copy link
Contributor

@dmccaffery are there any obvious downsides to replacing the ssh-agent?

Apple seems to have a history of letting the built-in cli tools lag. So I'm hesitant to say we should continue to use a less secure algorithm in the hopes Apple will ship support soon.

@dmccaffery
Copy link
Member Author

@dmccaffery are there any obvious downsides to replacing the ssh-agent?

Apple seems to have a history of letting the built-in cli tools lag. So I'm hesitant to say we should continue to use a less secure algorithm in the hopes Apple will ship support soon.

Apple lags due to licensing restrictions on the upstreams. Not sure why OpenSSH is lagging behind, specifically; other then it works for their use cases around Xcode as a development platform.

I'm all for replacing the built-ins; just wanted to get everyone's opinions.

@sjk07
Copy link
Member

sjk07 commented Dec 1, 2020

I am not currently using a security key... although I have thought about getting one a bunch of times

I do think security is important. If we are willing to support them for the time being (one of us have a vested use-case) then we should implement something that can and will work now.

@dmccaffery
Copy link
Member Author

I might have time this weekend to work on a POC to see what this looks like on macOS -- see what others think once implemented. @sjk07 : you should definitely get a key -- I use this guide (mostly): https://github.com/drduh/YubiKey-Guide

@sjk07
Copy link
Member

sjk07 commented Dec 10, 2020

I ended up folding and buying a Yubikey or two 😜

Ill follow the above; lets find a way to support this correctly

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 9, 2021
@sjk07
Copy link
Member

sjk07 commented Feb 9, 2021

Bumping this, I have a key but have not setup anything via terminal; i think this would be an awesome thing to have.

@github-actions github-actions bot removed the stale label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants