You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @jessepeterson! I noticed that the VirtualBoxExtPack.munki recipe has this in the installcheck_script:
VBM=/usr/local/bin/VBoxManage
if [ !-f$VBM ]
thenecho'VBoxManage not present'exit 0
fi
Which indicates that the extension pack should be installed if the VBoxManage binary is not present. However, the same recipe has a postinstall script that includes this:
if [ !-f$VBM ]
thenecho'VBoxManage not present'exit 1
fi
This will exit with an error if the same binary is not present.
Because the extension pack payload does not install the VBoxManage binary, wouldn't this result in looping? I think the answer is to change the installcheck_script to exit 1 instead of exit 0 but before I open a PR I wanted to make sure I'm not missing something.
The text was updated successfully, but these errors were encountered:
Hi @jessepeterson! I noticed that the VirtualBoxExtPack.munki recipe has this in the installcheck_script:
Which indicates that the extension pack should be installed if the VBoxManage binary is not present. However, the same recipe has a postinstall script that includes this:
This will exit with an error if the same binary is not present.
Because the extension pack payload does not install the VBoxManage binary, wouldn't this result in looping? I think the answer is to change the installcheck_script to
exit 1
instead ofexit 0
but before I open a PR I wanted to make sure I'm not missing something.The text was updated successfully, but these errors were encountered: