Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualBox extension pack installcheck_script question #69

Open
homebysix opened this issue May 5, 2018 · 0 comments
Open

VirtualBox extension pack installcheck_script question #69

homebysix opened this issue May 5, 2018 · 0 comments

Comments

@homebysix
Copy link
Member

Hi @jessepeterson! I noticed that the VirtualBoxExtPack.munki recipe has this in the installcheck_script:

VBM=/usr/local/bin/VBoxManage

if [ ! -f $VBM ]
then
	echo 'VBoxManage not present'
	exit 0
fi

Which indicates that the extension pack should be installed if the VBoxManage binary is not present. However, the same recipe has a postinstall script that includes this:

if [ ! -f $VBM ]
then
	echo 'VBoxManage not present'
	exit 1
fi

This will exit with an error if the same binary is not present.

Because the extension pack payload does not install the VBoxManage binary, wouldn't this result in looping? I think the answer is to change the installcheck_script to exit 1 instead of exit 0 but before I open a PR I wanted to make sure I'm not missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant