virsh_dump: drop --live option support

The --live flag was removed from virsh dump upstream, so any positive test that still use it now fails immediately.
ref: https://gitlab.com/libvirt/libvirt/-/issues/646

Delete all test cases that relied on --live, and add a negative test to make sure the command rejects the obsolete option.

Additionally, fix an unstable race by using utils_misc.wait_for(). Preventing the race condition where the log file had not yet been fully generated when the first check occurred.

Also fix an unstable teardown issue

Signed-off-by: zhentang-tz <[email protected]>

Author: zhentang-tz

libvirt/tests/cfg/guest_kernel_debugging/virsh_dump.cfg

@@ -20,14 +20,10 @@
                 - pause_dump:
                     paused_after_start_vm = "yes"
                     variants:
-                        - live:
-                            dump_options = "--live"
                         - crash:
                             dump_options = "--crash"
                         - reset:
                             dump_options = "--reset"
-                - live_dump:
-                    dump_options = "--live"
                 - crash_dump:
                     dump_options = "--crash"
                 - reset_dump:
@@ -89,6 +85,8 @@
                     dump_options = "--live --reset"
                 - invalid_option4:
                     dump_options = "--crash --reset"
+                - invalid_option_live:
+                    dump_options = "--live"    
                 - shutoff_dump:
                     start_vm = "no"
                 - acl_test:

libvirt/tests/cfg/virsh_cmd/monitor/virsh_domstate.cfg

@@ -77,8 +77,6 @@
                         - dump_vm:
                             domstate_vm_action = dump
                             variants:
-                                - dump_live:
-                                    dump_option = "--live"
                                 - dump_crash:
                                     dump_option = "--crash"
         - error_test:

libvirt/tests/src/guest_kernel_debugging/virsh_dump.py

@@ -66,6 +66,7 @@ def run(test, params, env):
             unprivileged_user = 'testacl'
     document_string = eval(params.get("document_string", "[]"))
     valid_format = ["lzop", "gzip", "bzip2", "xz", 'elf', 'data']
+    backup_xml = None
 
     if not libvirt_version.version_compare(1, 1, 1):
         if params.get('setup_libvirt_polkit') == 'yes':
@@ -334,7 +335,7 @@ def check_logfile(image_format):
         if not log_file:
             log_file = utils_misc.get_path(test.debugdir, "libvirtd.log")
         error = "Invalid dump_image_format.*" + image_format
-        return libvirt.check_logfile(error, log_file, ignore_status=True)
+        return utils_misc.wait_for(lambda: libvirt.check_logfile(error, log_file, ignore_status=True), timeout=30)
 
     # Configure dump_image_format in /etc/libvirt/qemu.conf.
     qemu_config = utils_config.LibvirtQemuConfig()
@@ -349,9 +350,12 @@ def check_logfile(image_format):
         qemu_config.dump_image_format = dump_image_format
         if dump_image_format not in valid_format:
             libvirtd.restart(wait_for_start=False)
-            if check_logfile(dump_image_format):
-                qemu_config.restore()
-                libvirtd_socket.restart()
+            err_msg_found = check_logfile(dump_image_format)
+            qemu_config.restore()
+            libvirtd_socket.restart()
+            if not err_msg_found:
+                test.fail("Cannot find the expected error message in log that indicates invalid image mode")
+            else:
                 return
         libvirtd.restart()
 
@@ -482,7 +486,8 @@ def check_logfile(image_format):
                 logging.info("Able to analyse guest vmcore using crash")
 
     finally:
-        backup_xml.sync()
+        if backup_xml:
+            backup_xml.sync()
         qemu_config.restore()
         libvirtd.restart()
         if os.path.isfile(small_img):