Autonomy Software WG Meeting 2022/03/29 #2485
BonoloAWF
started this conversation in
Working group meetings
Replies: 0 comments 2 replies
-
Discussion about localization: #112 |
Beta Was this translation helpful? Give feedback.
0 replies
-
If we have time, I would like to discuss about:
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Administrative
Attendees
Chaired by Fatih
Common Resources
Announcements
Autoware.Auto
Autoware.Universe
Discussion topics
Presentation: Scenario Runner Guide
Ryohsuke presented the scenario runner guide (see comments for presentation slides). Summary of the presentation:
Hatem (H) - how do you tell the scenario you want to run Autoware with it? I get an error "waiting for Autoware to initialise" Ryohsuke (R) - in the launch file of the scenario editor the default refers to autoware_launch_file.
Bonolo (B) - has it been implemented to link scenario tester to PRs? R - Authors of PRs will attach a target scenario to the PR and reviewers can run the scenario to evaluate the PR. We need to update the templates to include this.
Haoru (H) - how familiar should people be with scenario tests when developing future Autoware packages? R - I would like scenario testing to be the default way of testing in Autoware. In the PR template we can have a simple instruction added on how to run scenario testing as a reviewer.
Proposed by Ryohsuke:
If we have time, I would like to discuss about:
pip
orapt
for installing rockergdown
). Should modelzoo only support TVM models? or can it support other models. Who would maintain the repository?The rocker was previously installed using pip command but this was modified to be installed via apt. If anyone has a preference or experience with this please comment on the issue. The software architects will meet to discuss a framework for dealing with disagreements related to software development (usually voting works well).
Ryohsuke (R) - there are download bandwidth limitations which trigger additional costs per download. Center point model uses Tensor RT primers and would need to be converted to TVM in order to be included in the model zoo. Ambroise (A) - model zoo models are TVM based, additional work is required to support non-TVM models. R - Ambroise, do you know the setup for model zoo? A - Yes. Fatih (F) - for S3 bucket there is autoware.ai, autoware.auto, autoware-model-zoo, and autoware-gitlab-runner-cache. So far billing was around $400/month, there is more cost on the data transfer. Maybe we can use S3 bucket? A - S3 bucket for model zoo is for development only. Downloading models is disabled by default so it is lightly utilised since packages aren't actually using the models. This would significantly increase data transfer and associated costs. R - we should keep the same approach to auto disable downloads. We need to discuss further including moving the TVM pipeline to Universe.
Proposed by Fatih:
Universe has 2 packages for converting to Cartesian coordinates (eg. gnss_poser) which derives the PoseStamped and PoseWithCovarianceStamped msgs. GeographicLib provides a library for conversions which is easier to use. See: https://geographiclib.sourceforge.io/C++/doc/
Action Items
Review of issues
Ryohsuke - if CI passes, the Autoware.Auto MRs should get merged and the release can be completed. We want ADASTEC to test Autoware.Universe rather than Autoware.Auto. I can list the limitations identified so we can come up with tests for Universe packages.
Fatih - developers should review semantic pull request docs which check if the name of the PR matches the format require. All comments should be signed off according to DCO. See: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/#dco. Ryohsuke - these rules exist to improve traceability of changes made.
Beta Was this translation helpful? Give feedback.
All reactions