Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the autoware.universe/common packages #5077

Open
22 of 46 tasks
Tracked by #5079 ...
youtalk opened this issue Aug 13, 2024 · 9 comments
Open
22 of 46 tasks
Tracked by #5079 ...

Reorganize the autoware.universe/common packages #5077

youtalk opened this issue Aug 13, 2024 · 9 comments
Assignees
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.

Comments

@youtalk
Copy link
Member

youtalk commented Aug 13, 2024

Despite the name "common," the autoware.universe/common directory contains many packages that are only used by specific modules.

Move these packages to specific directories to clarify dependencies and relationships. This is a preparatory step for multi-containerization.

Packages in autoware.universe/common:

@youtalk youtalk self-assigned this Aug 13, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Aug 13, 2024
@youtalk youtalk removed their assignment Aug 13, 2024
@esteve
Copy link
Contributor

esteve commented Aug 14, 2024

@youtalk would it be useful to list the packages in common here so that we can check if they are truly "common" or can be moved?

@youtalk
Copy link
Member Author

youtalk commented Aug 14, 2024

@esteve It's good idea! Please do it.

@esteve
Copy link
Contributor

esteve commented Aug 14, 2024

@youtalk I've updated the issue description with a list of packages from common

@esteve
Copy link
Contributor

esteve commented Aug 14, 2024

I think the rviz plugin packages can most likely be moved elsewhere, this would make the OpenAD Kit Docker base images smaller.

@youtalk
Copy link
Member Author

youtalk commented Aug 14, 2024

Yeah, that's why #5076 was created.

@youtalk youtalk assigned youtalk and pojenwang and unassigned youtalk Aug 30, 2024
@youtalk youtalk removed their assignment Sep 3, 2024
@esteve esteve self-assigned this Oct 28, 2024
@esteve
Copy link
Contributor

esteve commented Nov 6, 2024

@youtalk some of the packages in common are rviz plugins, I think it'd be best to move the plugins elsewhere so we can make a smaller base image for OpenAD Kit, I'm focusing on refactoring the packages (adding the autoware prefix) that are not rviz plugins

@esteve
Copy link
Contributor

esteve commented Nov 6, 2024

@youtalk should the packages that have a tier4 prefix also have an autoware prefix? Or should they be renamed to only have autoware as their prefix?

@youtalk
Copy link
Member Author

youtalk commented Nov 7, 2024

@esteve Thank you for your feedback.

@youtalk some of the packages in common are rviz plugins, I think it'd be best to move the plugins elsewhere so we can make a smaller base image for OpenAD Kit, I'm focusing on refactoring the packages (adding the autoware prefix) that are not rviz plugins

Exactly. I think it would be a good idea to move all the RViz plugin packages either directly under autoware.universe or under the tools directory.
@mitsudome-r @xmfcx What do you think?

@youtalk should the packages that have a tier4 prefix also have an autoware prefix? Or should they be renamed to only have autoware as their prefix?

For now, let’s keep the package names with the tier4 suffix unchanged.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 7, 2024

I agree with moving them to reduce the base image size 👍

Some of the rviz plugins are crucial for running the Tutorials. (Basically any rviz plugin included in the main rviz config)

To alleviate this, we can first update the docs and then move.

Actions:

  1. Update https://autowarefoundation.github.io/autoware-documentation/main/installation/autoware/source-installation/#how-to-set-up-a-workspace and https://autowarefoundation.github.io/autoware-documentation/main/installation/autoware/source-installation/#how-to-update-a-workspace to include vcs import src < tools.repos
  2. Move the packages to tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

No branches or pull requests

4 participants