Skip to content

Commit f7c4099

Browse files
maru feedback
1 parent 7f67dcd commit f7c4099

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

tests/fixture/bootstrapmonitor/e2e/e2e_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,9 @@ var _ = ginkgo.Describe("[Bootstrap Tester]", func() {
141141
waitForPodCondition(tc, clientset, namespace, bootstrapPodName, corev1.PodReadyToStartContainers)
142142
ginkgo.By(fmt.Sprintf("Created pod %s.%s", namespace, bootstrapPodName))
143143

144+
ginkgo.By(fmt.Sprintf("Waiting for the %q container to report deletion of its pod to prompt recreation with a digest-pinned image", initContainerName))
145+
waitForLogOutput(tc, clientset, namespace, bootstrapPodName, initContainerName, bootstrapmonitor.PodDeletingMessage, "" /* wantImage */)
146+
144147
ginkgo.By("Waiting for the pod image to be updated to include an image digest")
145148
var containerImage string
146149
require.Eventually(func() bool {

tests/fixture/bootstrapmonitor/init.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const (
2828

2929
BootstrapStartingMessage = "Starting bootstrap test"
3030
BootstrapResumingMessage = "Resuming bootstrap test"
31+
PodDeletingMessage = "Deleting pod to trigger recreation with the digest-pinned image"
3132
)
3233

3334
var (
@@ -76,7 +77,8 @@ func InitBootstrapTest(log logging.Logger, namespace string, podName string, nod
7677
// The statefulset controller won't replace a pod that was never ready
7778
// (init blocks readiness), so self-delete, and let the digest-pinned
7879
// replacement make the start/resume decision.
79-
log.Info("Deleting pod to trigger recreation with the digest-pinned image",
80+
log.Info(PodDeletingMessage,
81+
zap.String("image", masterImageDetails.Image),
8082
zap.String("namespace", namespace),
8183
zap.String("pod", podName),
8284
zap.Duration("terminationTimeout", reapTimeout),

0 commit comments

Comments
 (0)