Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated validatorstest.TestState after bumping coreth version #3271

Closed
wants to merge 2 commits into from

Conversation

ARR4N
Copy link
Contributor

@ARR4N ARR4N commented Aug 6, 2024

Why this should be merged

To merge #3260 we had to depend on a commit from coreth that wasn't merged to master. Said branch has now been merged as ava-labs/coreth#620 so this PR updates the dep. It also removes the deprecated validatorstest.TestState that is no longer used by coreth.

Closes #3174

How this works

  1. Two parallel changes were made locally in avalanchego and coreth.
  2. A local go.work file was introduced to confirm that they were compatible.
  3. The coreth changes were pushed to a branch but not merged because that would break coreth CI.
  4. The changes in refactor: rename *test.Test* identifiers #3260 depended on the branch in (3) to avoid breaking avalanchego CI.
  5. The branch in (3) was merged as fix: use avalanchego new *test packages coreth#620.
  6. This PR depends on the commit merged in (5).
  7. Type this out just so I can use the Pepe SIlvia meme.

image

How this was tested

CI

@ARR4N
Copy link
Contributor Author

ARR4N commented Aug 15, 2024

Made redundant by #3277

@ARR4N ARR4N closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import of testing in production binary
1 participant