chore(customrawdb): delete customrawdb package and switch to avalanchego imports #4626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ego imports resolves #1302 Signed-off-by: Tsvetan Dimitrov ([email protected])
Handle database.ErrNotFound returned by ReadSyncRoot when there's no previous sync root. This is expected for fresh databases and should be treated as an empty hash (no previous sync) rather than an error.
Handle database.ErrNotFound from ReadAcceptorTip as expected case (empty hash) instead of error. This fixes VM initialization failures on fresh databases.
Update TestWipe to accept database.ErrNotFound as valid result after wipe, since ReadSnapshotBlockHash returns ErrNotFound when the marker doesn't exist.
- Move block number override fix before NewEVMBlockContext creation so GetHashFn can correctly resolve blockhash(n) when block number is overridden to n+1. This fixes TestTracingWithOverrides for Firewood scheme. - The bug was probably a pre-existing code issue where the header modification happened after creating the block context. Since GetHashFn creates a closure that captures the header reference, modifying the header afterward left the closure with stale values. This bug was exposed by the recent avalanchego update (3b08d61), which likely changed behavior that made the test fail specifically for Firewood scheme, while HashScheme continued to pass.
- Extract sentinel errors in journal.go for better error checking
and maintainability.
- Refactor loadSnapshot to use switch statements
for clearer control flow when validating snapshot block hash and root.
- Improve TestWipe validation logic:
- Use switch statements for consistent error handling patterns.
- Add context to error messages ("before wipe" / "after wipe").
powerslider
force-pushed
the
powerslider/1302-delete-customrawdb-package
branch
4 times, most recently
from
96abb67 to
831d8f3
Compare
powerslider
force-pushed
the
powerslider/1302-delete-customrawdb-package
branch
from
831d8f3 to
98a81dc
Compare
powerslider
commented
Nov 28, 2025
ceyonur
reviewed
Nov 28, 2025
Contributor
ceyonur
left a comment
ceyonur
left a comment
There was a problem hiding this comment.
just some cleanup from this PR. otherwise lgtm
powerslider
force-pushed
the
powerslider/1302-delete-customrawdb-package
branch
from
cbd8271 to
b77d79e
Compare
powerslider
force-pushed
the
powerslider/1302-delete-customrawdb-package
branch
from
b77d79e to
17f9aa3
Compare
ceyonur
reviewed
Dec 1, 2025
alarso16
reviewed
Dec 4, 2025
Comment on lines
+107
to
113
| switch { | ||
| case errors.Is(err, database.ErrNotFound): // Expected: marker was deleted. | ||
| case err != nil: | ||
| t.Errorf("unexpected error reading snapshot block hash after wipe: %v", err) | ||
| case blockHash != (common.Hash{}): | ||
| t.Errorf("snapshot block hash marker remained after wipe: %#x", blockHash) | ||
| } |
Contributor
There was a problem hiding this comment.
This doesn't check the blockhash if the error is database.ErrNotFound. Is that expected? Just looks like a bug at first glance
Contributor
There was a problem hiding this comment.
In either case, this definitely seems like it's a symptom of racy code. Will you add a comment describing why the error may or may not be nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Check #4569
How this works
graft/coreth/plugin/evm/customrawdb.github.com/ava-labs/avalanchego/vms/evm/sync/customrawdbimport instead.How this was tested
existing UT
Need to be documented?
no
Need to update RELEASES.md?
no
resolves #4569
Signed-off-by: Tsvetan Dimitrov ([email protected])