get it working

Author: SentryMan

blackbox-multi-scope/pom.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>io.avaje</groupId>
@@ -32,11 +32,11 @@
       <scope>test</scope>
     </dependency>
     <dependency>
-			<groupId>org.junit.jupiter</groupId>
-			<artifactId>junit-jupiter-params</artifactId>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-params</artifactId>
       <version>5.12.1</version>
-			<scope>test</scope>
-		</dependency>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>

inject-generator/src/main/java/io/avaje/inject/generator/SimpleModuleWriter.java

@@ -4,6 +4,7 @@
 import static io.avaje.inject.generator.APContext.typeElement;
 import static io.avaje.inject.generator.ProcessingContext.allScopes;
 import static io.avaje.inject.generator.ProcessingContext.createMetaInfWriterFor;
+import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toSet;
 
 import java.io.IOException;
@@ -12,7 +13,6 @@
 import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
-import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
@@ -106,25 +106,28 @@ void write() throws IOException {
   private void writeRequiredModules() {
 
     ProcessingContext.modules();
-    List<String> requiredModules = new ArrayList<>();
-
-    scopeInfo.requires().stream()
-        .map(APContext::typeElement)
-        .filter(InjectModulePrism::isPresent)
-        .filter(e -> e.getKind() == ElementKind.CLASS)
-        .map(TypeElement::getQualifiedName)
-        .map(Object::toString)
-        .forEach(requiredModules::add);
-      
-    scopeInfo.requires().stream()
-        .map(APContext::typeElement)
-        .filter(ScopePrism::isPresent)
-        .filter(e -> e.getKind() == ElementKind.ANNOTATION_TYPE)
-        .map(TypeElement::getQualifiedName)
-        .map(Object::toString)
-        .map(allScopes()::get)
-        .filter(Objects::nonNull)
-        .flatMap(scope -> scope.dependentScopes().stream())
+    Set<String> requiredModules = new HashSet<>();
+
+    var dependentScopes =
+        scopeInfo.requires().stream()
+            .map(APContext::typeElement)
+            .filter(ScopePrism::isPresent)
+            .filter(e -> e.getKind() == ElementKind.ANNOTATION_TYPE)
+            .map(TypeElement::getQualifiedName)
+            .map(Object::toString)
+            .map(allScopes()::get)
+            .filter(Objects::nonNull)
+            .flatMap(scope -> scope.dependentScopes().stream())
+            .collect(toList());
+
+    // don't write if dependent scopes have constructor params
+    for (var scope : dependentScopes) {
+      if (scope.requires().stream().map(allScopes()::get).anyMatch(Objects::isNull)) {
+        return;
+      }
+    }
+
+    dependentScopes.stream()
         .map(ScopeInfo::moduleFullName)
         .filter(Objects::nonNull)
         .filter(Predicate.not(String::isBlank))
@@ -133,13 +136,6 @@ private void writeRequiredModules() {
     final Map<String, String> dependencies =
         new LinkedHashMap<>(scopeInfo.constructorDependencies());
 
-    var scopes = ProcessingContext.allScopes();
-    
-    requiredModules.stream()
-      .forEach(module -> {
-        // Look up module dependencies (how?)
-      });
-
     writer.append("  public static AvajeModule[] allRequiredModules(");
 
     boolean comma = false;
@@ -157,20 +153,11 @@ private void writeRequiredModules() {
     writer.append("    return new AvajeModule[] {").eol();
 
     for (String rawType : requiredModules) {
-      writer.append("      new %s(", rawType).eol();
-
-      var scope = scopes.get(rawType);
-      if(Objects.nonNull(scope)) {
-        writer.append(String.join(", ", scope.constructorDependencies().values()));
-      } else {
-        // Look up module dependencies (how?)
-      }
-
-      writer.append("),", rawType).eol();
+      writer.append("      new %s(),", rawType).eol();
     }
     writer.append("      new %s(", shortName);
     writer.append(String.join(", ", scopeInfo.constructorDependencies().values()));
-    writer.append("),").eol();
+    writer.append(")").eol();
     writer.append("    };").eol();
     writer.append("  }").eol().eol();
   }