@@ -251,12 +251,15 @@ public BeanScope build() {
251
251
252
252
// sort factories by dependsOn
253
253
ModuleOrdering factoryOrder = new FactoryOrder (parent , includeModules , !suppliedBeans .isEmpty ());
254
- var modules = serviceLoader .modules ();
255
- if (factoryOrder .isEmpty ()) {
254
+
255
+ if (includeModules .isEmpty ()) {
256
+ var modules = serviceLoader .modules ();
256
257
// prefer generated ModuleOrdering if provided
257
- factoryOrder = serviceLoader .moduleOrdering ()
258
- .filter (o -> o .supportsExpected (modules ))
259
- .orElse (factoryOrder );
258
+ factoryOrder =
259
+ serviceLoader
260
+ .moduleOrdering ()
261
+ .filter (o -> o .supportsExpected (modules ))
262
+ .orElse (factoryOrder );
260
263
modules .forEach (factoryOrder ::add );
261
264
}
262
265
@@ -313,10 +316,9 @@ static class FactoryOrder implements ModuleOrdering {
313
316
314
317
FactoryOrder (BeanScope parent , Set <AvajeModule > includeModules , boolean suppliedBeans ) {
315
318
this .parent = parent ;
316
- this .factories .addAll (includeModules );
317
319
this .suppliedBeans = suppliedBeans ;
318
320
for (final AvajeModule includeModule : includeModules ) {
319
- moduleNames . add (includeModule . getClass (). getName () );
321
+ add (includeModule );
320
322
}
321
323
}
322
324
@@ -417,7 +419,7 @@ private boolean notProvided(String dependency) {
417
419
return false ;
418
420
}
419
421
final var factoryList = providesMap .get (dependency );
420
- return ( factoryList == null || !factoryList .allPushed () );
422
+ return factoryList == null || !factoryList .allPushed ();
421
423
}
422
424
423
425
/**
0 commit comments