I18n – Unneccessary usages of humanize?

[Timmitry]

I have an Avo::BaseResource where I'm specifying the translation key of the model, like e.g.:

class Avo::Resources::DatevPayment
  self.translation_key = "activerecord.models.datev_payment"
end

The translations include one and other. Since this is a german application, the other key translates to Datev-Zahlungen. However, in the sidebar menu, the entry is labeled as Datev-zahlungen (notice the small z). As far as I can see this stems from the two usages of humanize here:

avo/lib/avo/resources/base.rb

Lines 221 to 233 in 9937076

	def name_from_translation_key(count:, default:)
	t(translation_key, count:, default:).humanize
	rescue I18n::InvalidPluralizationData
	default
	end
	def underscore_name
	name.demodulize.underscore
	end
	def navigation_label
	plural_name.humanize
	end

Do we need the humanize at all? I would think that if I provide a translation, it should be used at is, without modifying the casing (note that in german, the first letter of a noun is always capitalized).

There are quite some other usages of humanize (~48 without specs and templates).

[Paul-Bob]

Do we need the humanize at all? I would think that if I provide a translation, it should be used at is

Agree. When a translation is provided, we should not apply humanize to it. The developer should have full control over the string that is displayed.

humanize should only be necessary when a translation is not provided and we are inferring the name from the class name.

---

There are quite some other usages of humanize (~48 without specs and templates).

Would you like to give it a try and open a PR? I would recommend focusing only on the cases that interfere with your use case and handling the remaining ones when needed, instead of analyzing every humanize usage now.

[Timmitry]

Thanks for your feedback! I can't promise that I'll find the time to work on this, but could be 🙂

Besides the actual code changes, I have some questions on how to tackle this:

• Should I add tests for the Avo::Resources::Base class (there are none yet), or where should this be tested?
• How should the I18n-testing happen? Should I just add entries to spec/dummy/config/locales/avo.en.yml, which I can then use in tests? I would like to have one entry that is looked up by default (avo.resource_translations.<class_name>, and one in another location (e.g. activerecord.models.<class_name>), which can be provided manually via self.translation_key = ....

[Paul-Bob]

Thanks for considering it!

• The tests can be added in spec/features/avo/i18n_spec.rb.
• We normally use the dummy app as a test ground, so you can set up a resource and a translation file in a way that matches what you want to test.