Skip to content

Commit 33dd434

Browse files
authored
Add integ test for #PR325 (#369)
* Add integ test for PR325
1 parent 3436c16 commit 33dd434

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

.github/workflows/test-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
id: render-task-definition-arn
5454
uses: aws-actions/amazon-ecs-render-task-definition@1048d8f8eb80d018c1bed7b5e3b252148bd6dfe5
5555
with:
56-
task-definition-arn: arn:aws:ecs:us-west-2:397300886559:task-definition/github-actions-render-task-definition-integ-tests:16
56+
task-definition-arn: arn:aws:ecs:us-west-2:${{ secrets.AWS_ACCOUNT_ID }}:task-definition/github-actions-render-task-definition-integ-tests:16
5757
container-name: sample-app
5858
image: amazon/amazon-ecs-sample:latest
5959

expected-task-definition.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,11 @@
2828
"FARGATE"
2929
],
3030
"networkMode": "awsvpc",
31-
"cpu": "256"
31+
"cpu": "256",
32+
"tags": [
33+
{
34+
"key": "test-name",
35+
"value": "github-actions-render-task-definition-integ-tests"
36+
}
37+
]
3238
}

task-definition.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,11 @@
2828
"FARGATE"
2929
],
3030
"networkMode": "awsvpc",
31-
"cpu": "256"
31+
"cpu": "256",
32+
"tags": [
33+
{
34+
"key": "test-name",
35+
"value": "github-actions-render-task-definition-integ-tests"
36+
}
37+
]
3238
}

test-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
id: render-task-definition-arn
5454
uses: aws-actions/amazon-ecs-render-task-definition@v1
5555
with:
56-
task-definition-arn: arn:aws:ecs:us-west-2:397300886559:task-definition/github-actions-render-task-definition-integ-tests:16
56+
task-definition-arn: arn:aws:ecs:us-west-2:${{ secrets.AWS_ACCOUNT_ID }}:task-definition/github-actions-render-task-definition-integ-tests:16
5757
container-name: sample-app
5858
image: amazon/amazon-ecs-sample:latest
5959

0 commit comments

Comments
 (0)