Emit logs on sterr stream (#459)

Author: satyakigh

src/app/initialize.ts

@@ -10,7 +10,7 @@ import { toString } from '../utils/String';
 export function staticInitialize(ClientInfo?: ClientInfo, AwsMetadata?: AwsMetadata) {
     if (!isTest) {
         // eslint-disable-next-line no-console
-        console.info(
+        console.error(
             toString({
                 Service: Service,
                 Environment: ServiceEnv,

src/app/standalone.ts

@@ -3,7 +3,6 @@ import { InitializedParams } from 'vscode-languageserver-protocol';
 import { LspCapabilities } from '../protocol/LspCapabilities';
 import { LspConnection } from '../protocol/LspConnection';
 import { ExtendedInitializeParams } from '../server/InitParams';
-import { LoggerFactory } from '../telemetry/LoggerFactory';
 import { ExtensionName } from '../utils/ExtensionConfig';
 import { staticInitialize } from './initialize';
 
@@ -24,16 +23,16 @@ async function onInitialize(params: ExtendedInitializeParams) {
 
 function onInitialized(params: InitializedParams) {
     (server as any).initialized(params);
-    getLogger().info(`${ExtensionName} initialized`);
+    console.error(`${ExtensionName} initialized`);
 }
 
 function onShutdown() {
-    console.info(`${ExtensionName} shutting down...`);
+    console.error(`${ExtensionName} shutting down...`);
     return (server as any).close();
 }
 
 function onExit() {
-    console.info(`${ExtensionName} exiting`);
+    console.error(`${ExtensionName} exiting`);
 }
 
 const lsp = new LspConnection(createConnection(ProposedFeatures.all), {
@@ -46,23 +45,8 @@ lsp.listen();
 
 process.on('unhandledRejection', (reason, _promise) => {
     console.error(reason, 'Unhandled promise rejection');
-
-    try {
-        getLogger().error(reason, 'Unhandled promise rejection');
-    } catch {
-        // do nothing
-    }
 });
 
 process.on('uncaughtException', (error, origin) => {
     console.error(error, `Unhandled exception ${origin}`);
-    try {
-        getLogger().error(error, `Uncaught exception ${origin}`);
-    } catch {
-        // do nothing
-    }
 });
-
-function getLogger() {
-    return LoggerFactory.getLogger('Init');
-}

src/telemetry/LoggerFactory.ts

@@ -37,6 +37,7 @@ export class LoggerFactory implements Closeable {
                     {
                         target: 'pino-pretty',
                         options: {
+                            destination: 2, // stderr — stdout is reserved for LSP JSON-RPC in --stdio mode
                             colorize: false,
                             translateTime: 'SYS:hh:MM:ss TT',
                             ignore: 'pid,hostname,name,clazz',

src/utils/Storage.ts

@@ -33,7 +33,7 @@ export class Storage {
     static initialize(storageDir?: string): void {
         this.root = storageDir ?? this.getDefaultStorageRoot();
         if (!isTest) {
-            console.info(`Initializing storage at ${this.root}`); // eslint-disable-line no-console
+            console.error(`Initializing storage at ${this.root}`); // eslint-disable-line no-console
         }
         this.cleanupLegacyStorage();
     }