-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS MSK - Updates doesn't work with kafka-controller #2249
Labels
kind/bug
Categorizes issue or PR as related to a bug.
needs-investigation
Indicates an issue needs some investigation.
service/kafka
Indicates issues or PRs that are related to kafka-controller.
target/q1-2025
Issues scheduled for Q1 in 2025
Comments
Indeed looks like there is a missing logic for volume size/instance type updates in https://github.com/aws-controllers-k8s/kafka-controller/blob/main/pkg/resource/cluster/hooks.go#L114-L155 |
Hey @kkopuru |
Hi @michaelhtm
|
ack-prow bot
pushed a commit
to aws-controllers-k8s/kafka-controller
that referenced
this issue
Mar 5, 2025
Loading
Loading status checks…
) Issue [#2249](aws-controllers-k8s/community#2249) Description of changes: Also added reconcile before deletion attempt if cluster is not active. Before, if we tried deleting a cluster that was not active, the controller would set it to terminal, and does not reconcile. Another change being added is a field in the Cluster status called ClusterVersion. This field is returned by the sdkFind operation, and is crutial to make updates to VolumeSize, InstanceType, and BrokerCount. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi @kkopuru, is this issue resolved for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
needs-investigation
Indicates an issue needs some investigation.
service/kafka
Indicates issues or PRs that are related to kafka-controller.
target/q1-2025
Issues scheduled for Q1 in 2025
Provisioning of AWS MSK using kafka-controller works fine but any updates to existing deployment doesn't work. Any updates like volume size, instance type etc are not getting rolled out.
Environment:
The text was updated successfully, but these errors were encountered: