Feature Flags Format

[phillipstr]

Describe the bug
Fresh install of AWS Controllers for Kubernetes - Amazon EC2 from the OpenShift OperatorHub gets stuck in CrashLoopBackOff with this message in the controller logs

2025-01-28T15:51:18.594Z ERROR setup Unable to create controller manager {"aws.service": "ec2", "error": "invalid value for flag 'feature-gates': invalid feature gate format: $(FEATURE_GATES)"}
main.main
/github.com/aws-controllers-k8s/ec2-controller/cmd/controller/main.go:89
runtime.main
/usr/local/go/src/runtime/proc.go:272

Removing these args from the replicaSet allows the pod to start up, but I can't imagine that's the correct way to resolve this.

            - '--feature-gates'
            - $(FEATURE_GATES)

Steps to reproduce
Install v1.3.1 channel alpha from OperatorHub following the ACK documentation

Expected outcome
AWS Controllers for Kubernetes - Amazon EC2 installs and is usable

Environment
OpenShift Version: 4.17.11
Kubernetes Version: v1.30.7

[michaelhtm]

Hi @acornett21, can you please take a look at this issue?

[acornett21]

@michaelhtm The below PR should have updated the documentation to include FEATURE_GATES into the ConfigMap

• CausedBy: Add FEATURE_GATES env to controller deployment template code-generator#559

The ClusterServiceVersion(CSV) does not have default values, since they can't be changed out at runtime, the come from a ConfigMap. So the controller is seeing $(FEATURE_GATES) as a literal value and throwing an error.