-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Supports customization mapping addtional details to HTTP events #599
Comments
Thanks for the clear and concise request! I think this would be a good feature and is needed. My intuition is that we could add a parameter to the HTTP plugin configuration. @AllanZhengYP would you be interested in submitting a PR? @williazz do you have any thoughts? Any risks? |
Awesome idea. People have asked similar questions in the past about scraping information from the response. Security wise, this puts greater strain on the Shared Responsibility Model so we have shied away from these ideas in the past. But I think it's doable because we have a very good reason. If you are interested in submitting a PR, I would suggest limiting the scope to |
@williazz Thanks for the quick follow up. We do have a few use cases where we do need to collect the request & response headers beyond just Understandably, the shared responsibility model discourages the interfaces that could potentially be used incorrectly. What do you think a configuration only sets addtional boolean attribute if a given header is set? |
Technically, RUM service team is only responsible for the security of the cloud. We are not responsible for deciding what data users want to log. Why don't you just give it a go with the headers you are interested in? Users are always free to fork this repo and scrape whatever data they want as custom events, so this decision should not block you. |
There are a couple of problems with the custom events from where I can see:
|
Please provide your feature request
Our use case: when HTTP error happens, we want to find out the if the error is from requests to AWS service endpoints. If so, we want to collect the request IDs from the error response. So we can file tickets to the service team to investigate the service log if needed.
Gap: The request IDs are normally present in the response headers(e.g.
x-amz-request-id
). Currently the HTTP events does not have a way to enrich the event with information from headers.Proposed solution: Provide a configuration to map request/response headers into additional attributes to HTTP events. Maybe we need to same for error events as well. Similarly to enrich the error events with addtional attributes from our Error classes.
Current workaround: Currently we have to replicate the CHR/Fetch/Error plugin implimentation but add addtional shimmings.
The text was updated successfully, but these errors were encountered: