-
Notifications
You must be signed in to change notification settings - Fork 620
/
Copy pathtask_test.go
5432 lines (4853 loc) · 171 KB
/
task_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
//go:build unit
// +build unit
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license" file accompanying this file. This file is distributed
// on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.
package task
import (
"encoding/json"
"fmt"
"reflect"
"runtime"
"strconv"
"strings"
"testing"
"time"
"github.com/aws/amazon-ecs-agent/agent/api/serviceconnect"
"github.com/aws/amazon-ecs-agent/agent/taskresource/credentialspec"
"github.com/docker/go-connections/nat"
apicontainer "github.com/aws/amazon-ecs-agent/agent/api/container"
"github.com/aws/amazon-ecs-agent/agent/asm"
mock_asm_factory "github.com/aws/amazon-ecs-agent/agent/asm/factory/mocks"
mock_factory "github.com/aws/amazon-ecs-agent/agent/asm/factory/mocks"
mock_secretsmanageriface "github.com/aws/amazon-ecs-agent/agent/asm/mocks"
"github.com/aws/amazon-ecs-agent/agent/config"
"github.com/aws/amazon-ecs-agent/agent/dockerclient"
"github.com/aws/amazon-ecs-agent/agent/dockerclient/dockerapi"
mock_dockerapi "github.com/aws/amazon-ecs-agent/agent/dockerclient/dockerapi/mocks"
mock_s3_factory "github.com/aws/amazon-ecs-agent/agent/s3/factory/mocks"
mock_ssm_factory "github.com/aws/amazon-ecs-agent/agent/ssm/factory/mocks"
"github.com/aws/amazon-ecs-agent/agent/taskresource"
"github.com/aws/amazon-ecs-agent/agent/taskresource/asmauth"
resourcestatus "github.com/aws/amazon-ecs-agent/agent/taskresource/status"
taskresourcevolume "github.com/aws/amazon-ecs-agent/agent/taskresource/volume"
"github.com/aws/amazon-ecs-agent/agent/utils"
"github.com/aws/amazon-ecs-agent/ecs-agent/acs/model/ecsacs"
apiresource "github.com/aws/amazon-ecs-agent/ecs-agent/api/attachment/resource"
apicontainerstatus "github.com/aws/amazon-ecs-agent/ecs-agent/api/container/status"
"github.com/aws/amazon-ecs-agent/ecs-agent/api/ecs/model/ecs"
apitaskstatus "github.com/aws/amazon-ecs-agent/ecs-agent/api/task/status"
"github.com/aws/amazon-ecs-agent/ecs-agent/credentials"
mock_credentials "github.com/aws/amazon-ecs-agent/ecs-agent/credentials/mocks"
ni "github.com/aws/amazon-ecs-agent/ecs-agent/netlib/model/networkinterface"
commonutils "github.com/aws/amazon-ecs-agent/ecs-agent/utils"
"github.com/aws/aws-sdk-go/service/secretsmanager"
"github.com/aws/amazon-ecs-agent/agent/taskresource/asmsecret"
"github.com/aws/amazon-ecs-agent/agent/taskresource/envFiles"
"github.com/aws/amazon-ecs-agent/agent/taskresource/ssmsecret"
"github.com/aws/aws-sdk-go/aws"
dockercontainer "github.com/docker/docker/api/types/container"
"github.com/docker/docker/api/types/volume"
"github.com/docker/go-units"
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
const (
serviceConnectContainerTestName = "service-connect"
testHostName = "testHostName"
testOutboundListenerName = "testOutboundListener"
testIPv4Address = "172.31.21.40"
testIPv6Address = "abcd:dcba:1234:4321::"
testIPv4Cidr = "127.255.0.0/16"
testIPv6Cidr = "2002::1234:abcd:ffff:c0a8:101/64"
)
var (
testListenerPort = uint16(8080)
testBridgeDefaultListenerPort = uint16(15000)
testEBSReadOnly = false
)
func TestDockerConfigPortBinding(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
Ports: []apicontainer.PortBinding{
{
ContainerPort: 10,
HostPort: 10,
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
{
ContainerPort: 20,
HostPort: 20,
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
{
ContainerPortRange: "99-999",
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
{
ContainerPortRange: "121-221",
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
},
},
},
}
config, err := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
if err != nil {
t.Error(err)
}
_, ok := config.ExposedPorts["10/tcp"]
if !ok {
t.Fatal("Could not get exposed ports 10/tcp")
}
_, ok = config.ExposedPorts["20/udp"]
if !ok {
t.Fatal("Could not get exposed ports 20/udp")
}
startContainerPortTcp, endContainerPortTcp, tcpParseErr := nat.ParsePortRangeToInt("99-999")
if tcpParseErr != nil {
t.Fatal("Error parsing tcp port range into start and end ints")
}
for i := startContainerPortTcp; i <= endContainerPortTcp; i++ {
portProtocol := nat.Port(fmt.Sprintf("%d/tcp", i))
_, ok := config.ExposedPorts[portProtocol]
if !ok {
t.Fatalf("Could not get exposed ports %s", portProtocol)
}
}
startContainerPortUdp, endContainerPortUdp, udpParseErr := nat.ParsePortRangeToInt("121-221")
if udpParseErr != nil {
t.Fatal("Error parsing udp port range into start and end ints")
}
for i := startContainerPortUdp; i <= endContainerPortUdp; i++ {
portProtocol := nat.Port(fmt.Sprintf("%d/udp", i))
_, ok := config.ExposedPorts[portProtocol]
if !ok {
t.Fatalf("Could not get exposed ports %s", portProtocol)
}
}
}
func TestDockerConfigPortBindingContainerPortIsZero(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "ContainerHavingPortBindingWithContainerPortZero",
Ports: []apicontainer.PortBinding{
{
ContainerPort: 0,
HostPort: 10,
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
{
ContainerPort: 0,
HostPort: 20,
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
},
},
},
}
dockerContainerConfig, err := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
assert.Nil(t, err)
// Ensure that port zero is not included in the set of container ports that are exposed for the container.
_, ok := dockerContainerConfig.ExposedPorts["0/tcp"]
assert.False(t, ok, "Unexpectedly could get exposed ports 0/tcp")
_, ok = dockerContainerConfig.ExposedPorts["0/udp"]
assert.False(t, ok, "Unexpectedly could get exposed ports 0/udp")
}
func TestDockerHostConfigCPUShareZero(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
CPU: 0,
},
},
}
hostconfig, err := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
if err != nil {
t.Error(err)
}
if runtime.GOOS == "windows" {
if hostconfig.CPUShares != 0 {
// CPUShares will always be 0 on windows
t.Error("CPU shares expected to be 0 on windows")
}
} else if hostconfig.CPUShares != 2 {
t.Error("CPU shares of 0 did not get changed to 2")
}
}
func TestDockerHostConfigCPUShareMinimum(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
CPU: 1,
},
},
}
hostconfig, err := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
if err != nil {
t.Error(err)
}
if runtime.GOOS == "windows" {
if hostconfig.CPUShares != 0 {
// CPUShares will always be 0 on windows
t.Error("CPU shares expected to be 0 on windows")
}
} else if hostconfig.CPUShares != 2 {
t.Error("CPU shares of 0 did not get changed to 2")
}
}
func TestDockerHostConfigCPUShareUnchanged(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
CPU: 100,
},
},
}
hostconfig, err := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
if err != nil {
t.Error(err)
}
if runtime.GOOS == "windows" {
if hostconfig.CPUShares != 0 {
// CPUShares will always be 0 on windows
t.Error("CPU shares expected to be 0 on windows")
}
} else if hostconfig.CPUShares != 100 {
t.Error("CPU shares unexpectedly changed")
}
}
func TestDockerHostConfigPortBinding(t *testing.T) {
testTask1 := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
Ports: []apicontainer.PortBinding{
{
ContainerPort: 10,
HostPort: 20,
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
{
ContainerPort: 20,
HostPort: 30,
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
},
},
},
}
testTask2 := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
Ports: []apicontainer.PortBinding{
{
ContainerPort: 10,
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
{
ContainerPort: 20,
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
{
ContainerPort: 30,
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
},
},
},
}
testTask3 := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
Ports: []apicontainer.PortBinding{
{
ContainerPortRange: "55-57",
BindIP: "",
Protocol: apicontainer.TransportProtocolUDP,
},
{
ContainerPort: 80,
BindIP: "",
Protocol: apicontainer.TransportProtocolTCP,
},
},
},
},
}
testCases := []struct {
testName string
testTask *Task
testDynamicHostPortRange string
testContainerPortRange string
expectedPortBinding nat.PortMap
expectedContainerPortSet map[int]struct{}
expectedContainerPortRangeMap map[string]string
expectedError bool
}{
{
testName: "user-specified container ports and host ports",
testTask: testTask1,
testDynamicHostPortRange: "40000-60000",
expectedPortBinding: nat.PortMap{
nat.Port("10/tcp"): []nat.PortBinding{{HostPort: "20"}},
nat.Port("20/udp"): []nat.PortBinding{{HostPort: "30"}},
},
expectedContainerPortSet: map[int]struct{}{
10: {},
20: {},
},
expectedContainerPortRangeMap: map[string]string{},
},
{
testName: "user-specified container ports with a ideal dynamicHostPortRange",
testTask: testTask2,
testDynamicHostPortRange: "40000-60000",
expectedContainerPortSet: map[int]struct{}{
10: {},
20: {},
30: {},
},
expectedContainerPortRangeMap: map[string]string{},
},
{
testName: "user-specified container ports with a bad dynamicHostPortRange",
testTask: testTask2,
testDynamicHostPortRange: "100-101",
expectedError: true,
},
{
testName: "user-specified container port and container port range with a ideal dynamicHostPortRange",
testTask: testTask3,
testDynamicHostPortRange: "40000-60000",
testContainerPortRange: "55-57",
expectedContainerPortSet: map[int]struct{}{
80: {},
},
},
{
testName: "user-specified container port and container port range with a bad user-specified dynamicHostPortRange",
testTask: testTask3,
testDynamicHostPortRange: "40000-40001",
testContainerPortRange: "55-57",
expectedError: true,
},
}
for _, tc := range testCases {
t.Run(tc.testName, func(t *testing.T) {
defer func() {
getHostPortRange = utils.GetHostPortRange
}()
// Get the Docker host config for the task container
config, err := tc.testTask.DockerHostConfig(tc.testTask.Containers[0], dockerMap(tc.testTask),
defaultDockerClientAPIVersion, &config.Config{DynamicHostPortRange: tc.testDynamicHostPortRange})
if !tc.expectedError {
assert.Nil(t, err)
// Verify PortBindings
if tc.expectedPortBinding != nil {
if !reflect.DeepEqual(config.PortBindings, tc.expectedPortBinding) {
t.Error("Expected port bindings to be resolved, was: ", config.PortBindings)
}
}
// Verify ContainerPortSet
if !reflect.DeepEqual(tc.testTask.Containers[0].ContainerPortSet, tc.expectedContainerPortSet) {
t.Error("Expected container port set to be resolved, was: ", tc.testTask.Containers[0].GetContainerPortSet())
}
// Verify ContainerPortRangeMap
if tc.expectedContainerPortRangeMap != nil {
if !reflect.DeepEqual(tc.testTask.Containers[0].ContainerPortRangeMap, tc.expectedContainerPortRangeMap) {
t.Error("Expected container port range map to be resolved, was: ", tc.testTask.Containers[0].GetContainerPortRangeMap())
}
}
} else {
assert.NotNil(t, err)
}
})
}
}
var (
SCTaskContainerPort1 uint16 = 8080
SCTaskContainerPort2 uint16 = 9090
SCIngressListener1ContainerPort uint16 = 15000
SCIngressListener2ContainerPort uint16 = 16000
SCIngressListener2HostPort uint16 = 17000
SCEgressListenerContainerPort uint16 = 12345
defaultSCProtocol = "/tcp"
)
func getDefaultDynamicHostPortRange() (start int, end int) {
startHostPortRange, endHostPortRange, err := utils.GetDynamicHostPortRange()
if err != nil {
return utils.DefaultPortRangeStart, utils.DefaultPortRangeEnd
}
return startHostPortRange, endHostPortRange
}
func getTestTaskServiceConnectBridgeMode() *Task {
testTask := &Task{
NetworkMode: BridgeNetworkMode,
Containers: []*apicontainer.Container{
{
Name: "C1",
Ports: []apicontainer.PortBinding{
{ContainerPort: SCTaskContainerPort1, HostPort: 0, BindIP: "", Protocol: apicontainer.TransportProtocolTCP},
{ContainerPort: SCTaskContainerPort2, HostPort: 0, BindIP: "", Protocol: apicontainer.TransportProtocolTCP},
},
NetworkModeUnsafe: "", // should later be overridden to container mode
},
{
Name: fmt.Sprintf("%s-%s", NetworkPauseContainerName, "C1"),
Type: apicontainer.ContainerCNIPause,
NetworkModeUnsafe: "", // should later be overridden to explicit bridge mode
},
{
Name: serviceConnectContainerTestName, // port binding is retrieved through listener config and published by pause container
NetworkModeUnsafe: "", // should later be overridden to container mode
},
{
Name: fmt.Sprintf("%s-%s", NetworkPauseContainerName, serviceConnectContainerTestName),
Type: apicontainer.ContainerCNIPause,
NetworkModeUnsafe: "", // should later be overridden to explicit bridge mode
},
},
}
testTask.ServiceConnectConfig = &serviceconnect.Config{
ContainerName: serviceConnectContainerTestName,
IngressConfig: []serviceconnect.IngressConfigEntry{
{
ListenerName: "testListener1", // bridge mode default - ephemeral listener host port
ListenerPort: SCIngressListener1ContainerPort,
},
{
ListenerName: "testListener2", // bridge mode non-default - user-specified listener host port
ListenerPort: SCIngressListener2ContainerPort,
HostPort: &SCIngressListener2HostPort,
},
},
EgressConfig: &serviceconnect.EgressConfig{
ListenerName: "testEgressListener",
ListenerPort: SCEgressListenerContainerPort, // Presently this should always get ephemeral port
},
}
return testTask
}
func convertSCPort(port uint16) nat.Port {
return nat.Port(strconv.Itoa(int(port)) + defaultSCProtocol)
}
// TestDockerHostConfigSCBridgeMode verifies port bindings and network mode overrides for each
// container in an SC-enabled bridge mode task with default/user-specified dynamic host port range.
// The test task is consisted of the SC container, a regular container,
// and two pause containers associated with each.
func TestDockerHostConfigSCBridgeMode(t *testing.T) {
testTask := getTestTaskServiceConnectBridgeMode()
testCases := []struct {
testStartHostPort int
testEndHostPort int
testName string
testError bool
}{
{
testStartHostPort: 0,
testEndHostPort: 0,
testName: "with default dynamic host port range",
},
{
testStartHostPort: 50000,
testEndHostPort: 60000,
testName: "with user-specified dynamic host port range",
},
}
for _, tc := range testCases {
t.Run(tc.testName, func(t *testing.T) {
// need to reset the tracker to avoid getting data from previous test cases
utils.ResetTracker()
if tc.testStartHostPort == 0 && tc.testEndHostPort == 0 {
tc.testStartHostPort, tc.testEndHostPort = getDefaultDynamicHostPortRange()
}
testDynamicHostPortRange := fmt.Sprintf("%d-%d", tc.testStartHostPort, tc.testEndHostPort)
testConfig := &config.Config{DynamicHostPortRange: testDynamicHostPortRange}
// task container and SC container should both get empty port binding map and "container" network mode
// the task container
actualConfig, err := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion, testConfig)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Equal(t, dockercontainer.NetworkMode(fmt.Sprintf("%s-%s", // e.g. "container:dockerid-~internal~ecs~pause-C1"
dockerMappingContainerPrefix+dockerIDPrefix+NetworkPauseContainerName, "C1")), actualConfig.NetworkMode)
assert.Empty(t, actualConfig.PortBindings, "Task container port binding should be empty")
// the service connect container
actualConfig, err = testTask.DockerHostConfig(testTask.Containers[2], dockerMap(testTask), defaultDockerClientAPIVersion, testConfig)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Equal(t, dockercontainer.NetworkMode(fmt.Sprintf("%s-%s", // e.g. "container:dockerid-~internal~ecs~pause-C1"
dockerMappingContainerPrefix+dockerIDPrefix+NetworkPauseContainerName, serviceConnectContainerTestName)), actualConfig.NetworkMode)
assert.Empty(t, actualConfig.PortBindings, "SC container port binding should be empty")
// task pause container should get port binding map of the task container
actualConfig, err = testTask.DockerHostConfig(testTask.Containers[1], dockerMap(testTask), defaultDockerClientAPIVersion, testConfig)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Equal(t, dockercontainer.NetworkMode(BridgeNetworkMode), actualConfig.NetworkMode)
bindings, ok := actualConfig.PortBindings[convertSCPort(SCTaskContainerPort1)]
assert.True(t, ok, "Could not get port bindings")
assert.Equal(t, 1, len(bindings), "Wrong number of bindings")
bindings, ok = actualConfig.PortBindings[convertSCPort(SCTaskContainerPort2)]
assert.True(t, ok, "Could not get port bindings")
assert.Equal(t, 1, len(bindings), "Wrong number of bindings")
// SC pause container should get port binding map of all ingress listeners
actualConfig, err = testTask.DockerHostConfig(testTask.Containers[3], dockerMap(testTask), defaultDockerClientAPIVersion, testConfig)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Equal(t, dockercontainer.NetworkMode(BridgeNetworkMode), actualConfig.NetworkMode)
// SC - ingress listener 1 - default experience
bindings, ok = actualConfig.PortBindings[convertSCPort(SCIngressListener1ContainerPort)]
assert.True(t, ok, "Could not get port bindings")
// SC - ingress listener 2 - non-default host port
bindings, ok = actualConfig.PortBindings[convertSCPort(SCIngressListener2ContainerPort)]
assert.True(t, ok, "Could not get port bindings")
assert.Equal(t, 1, len(bindings), "Wrong number of bindings")
assert.Equal(t, strconv.Itoa(int(SCIngressListener2HostPort)), bindings[0].HostPort, "Wrong hostport")
// SC - egress listener - should not have port binding
bindings, ok = actualConfig.PortBindings[convertSCPort(SCEgressListenerContainerPort)]
assert.False(t, ok, "egress listener has port binding but it shouldn't")
})
}
}
// TestDockerHostConfigSCBridgeMode_getPortBindingFailure verifies that when we can't find the task
// container associated with the pause container, DockerHostConfig should return failure (from getPortBinding)
func TestDockerHostConfigSCBridgeMode_getPortBindingFailure(t *testing.T) {
testTask := getTestTaskServiceConnectBridgeMode()
testTask.Containers[1].Name = "invalid" // make the pause container name invalid such that we can't resolve task container from it
_, err := testTask.DockerHostConfig(testTask.Containers[1], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.NotNil(t, err)
assert.True(t, strings.Contains(err.Msg, "error retrieving docker port map"))
}
// TestDockerContainerConfigSCBridgeMode verifies exposed port and uid configuration for each container
// in an SC-enabled bridge mode task. The test task is consisted of the SC container, a regular container,
// and two pause container associated with each of them.
func TestDockerContainerConfigSCBridgeMode(t *testing.T) {
testTask := getTestTaskServiceConnectBridgeMode()
// Containers[0] aka user-defined task container should NOT expose any ports (it's done through the associated pause container)
// It should NOT get UID override
actualConfig, err := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Empty(t, actualConfig.ExposedPorts)
assert.Empty(t, actualConfig.User)
// Containers[2] aka SC container should NOT expose any ports (it's done through the associated pause container)
// It should get UID override
actualConfig, err = testTask.DockerConfig(testTask.Containers[2], defaultDockerClientAPIVersion)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.Empty(t, actualConfig.ExposedPorts)
assert.Equal(t, strconv.Itoa(serviceconnect.AppNetUID), actualConfig.User)
// Containers[1] aka task pause container should expose all container ports from the associated user-defined task containers
// It should NOT get UID override
actualConfig, err = testTask.DockerConfig(testTask.Containers[1], defaultDockerClientAPIVersion)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.NotNil(t, actualConfig.ExposedPorts)
assert.Equal(t, 2, len(actualConfig.ExposedPorts))
_, ok := actualConfig.ExposedPorts[convertSCPort(SCTaskContainerPort1)]
assert.True(t, ok)
_, ok = actualConfig.ExposedPorts[convertSCPort(SCTaskContainerPort2)]
assert.True(t, ok)
assert.Empty(t, actualConfig.User)
// Containers[3] aka SC pause container should expose all container ports from SC ingress and egress listeners
// It should NOT get UID override
actualConfig, err = testTask.DockerConfig(testTask.Containers[3], defaultDockerClientAPIVersion)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.NotNil(t, actualConfig.ExposedPorts)
assert.Equal(t, 3, len(actualConfig.ExposedPorts))
_, ok = actualConfig.ExposedPorts[convertSCPort(SCIngressListener1ContainerPort)]
assert.True(t, ok)
_, ok = actualConfig.ExposedPorts[convertSCPort(SCIngressListener2ContainerPort)]
assert.True(t, ok)
_, ok = actualConfig.ExposedPorts[convertSCPort(SCEgressListenerContainerPort)]
assert.True(t, ok)
assert.Empty(t, actualConfig.User)
}
func TestDockerContainerConfigSCBridgeMode_getExposedPortsFailure(t *testing.T) {
testTask := getTestTaskServiceConnectBridgeMode()
testTask.Containers[1].Name = "invalid" // make the pause container name invalid such that we can't resolve task container from it
_, err := testTask.DockerConfig(testTask.Containers[1], defaultDockerClientAPIVersion)
assert.NotNil(t, err)
assert.True(t, strings.Contains(err.Msg, "error resolving docker exposed ports"))
}
func TestDockerContainerConfigSCBridgeMode_emptyEgressConfig(t *testing.T) {
testTask := getTestTaskServiceConnectBridgeMode()
testTask.ServiceConnectConfig.EgressConfig = nil
actualConfig, err := testTask.DockerConfig(testTask.Containers[3], defaultDockerClientAPIVersion)
assert.Nil(t, err)
assert.NotNil(t, actualConfig)
assert.NotNil(t, actualConfig.ExposedPorts)
assert.Equal(t, 2, len(actualConfig.ExposedPorts))
_, ok := actualConfig.ExposedPorts[convertSCPort(SCIngressListener1ContainerPort)]
assert.True(t, ok)
_, ok = actualConfig.ExposedPorts[convertSCPort(SCIngressListener2ContainerPort)]
assert.True(t, ok)
}
func TestDockerHostConfigVolumesFrom(t *testing.T) {
testTask := &Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
},
{
Name: "c2",
VolumesFrom: []apicontainer.VolumeFrom{{SourceContainer: "c1"}},
},
},
}
config, err := testTask.DockerHostConfig(testTask.Containers[1], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
if !reflect.DeepEqual(config.VolumesFrom, []string{"dockername-c1"}) {
t.Error("Expected volumesFrom to be resolved, was: ", config.VolumesFrom)
}
}
func TestDockerHostConfigRawConfig(t *testing.T) {
rawHostConfigInput := dockercontainer.HostConfig{
Privileged: true,
ReadonlyRootfs: true,
DNS: []string{"dns1, dns2"},
DNSSearch: []string{"dns.search"},
ExtraHosts: []string{"extra:hosts"},
SecurityOpt: []string{"foo", "bar"},
Resources: dockercontainer.Resources{
CPUShares: 2,
Ulimits: []*units.Ulimit{{Name: "ulimit name", Soft: 10, Hard: 100}},
},
LogConfig: dockercontainer.LogConfig{
Type: "foo",
Config: map[string]string{"foo": "bar"},
},
}
rawHostConfig, err := json.Marshal(&rawHostConfigInput)
if err != nil {
t.Fatal(err)
}
testTask := &Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
DockerConfig: apicontainer.DockerConfig{
HostConfig: strptr(string(rawHostConfig)),
},
},
},
}
config, configErr := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, configErr)
expectedOutput := rawHostConfigInput
expectedOutput.CPUPercent = minimumCPUPercent
if runtime.GOOS == "windows" {
// CPUShares will always be 0 on windows
expectedOutput.CPUShares = 0
}
assertSetStructFieldsEqual(t, expectedOutput, *config)
}
func TestDockerHostConfigPauseContainer(t *testing.T) {
testTask := &Task{
ENIs: []*ni.NetworkInterface{
{
ID: "eniID",
},
},
NetworkMode: AWSVPCNetworkMode,
Containers: []*apicontainer.Container{
{
Name: "c1",
},
{
Name: NetworkPauseContainerName,
Type: apicontainer.ContainerCNIPause,
},
},
}
customContainer := testTask.Containers[0]
pauseContainer := testTask.Containers[1]
// Verify that the network mode is set to "container:<pause-container-docker-id>"
// for a non pause container
cfg, err := testTask.DockerHostConfig(customContainer, dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, "container:"+dockerIDPrefix+NetworkPauseContainerName, string(cfg.NetworkMode))
// Verify that the network mode is not set to "none" for the
// empty volume container
cfg, err = testTask.DockerHostConfig(testTask.Containers[1], dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, networkModeNone, string(cfg.NetworkMode))
// Verify that the network mode is set to "none" for the pause container
cfg, err = testTask.DockerHostConfig(pauseContainer, dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, networkModeNone, string(cfg.NetworkMode))
// Verify that overridden DNS settings are set for the pause container
// and not set for non pause containers
testTask.ENIs[0].DomainNameServers = []string{"169.254.169.253"}
testTask.ENIs[0].DomainNameSearchList = []string{"us-west-2.compute.internal"}
// DNS overrides are only applied to the pause container. Verify that the non-pause
// container contains no overrides
cfg, err = testTask.DockerHostConfig(customContainer, dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, 0, len(cfg.DNS))
assert.Equal(t, 0, len(cfg.DNSSearch))
// Verify DNS settings are overridden for the pause container
cfg, err = testTask.DockerHostConfig(pauseContainer, dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, []string{"169.254.169.253"}, cfg.DNS)
assert.Equal(t, []string{"us-west-2.compute.internal"}, cfg.DNSSearch)
// Verify eni ExtraHosts added to HostConfig for pause container
ipaddr := &ni.IPV4Address{Primary: true, Address: "10.0.1.1"}
testTask.ENIs[0].IPV4Addresses = []*ni.IPV4Address{ipaddr}
testTask.ENIs[0].PrivateDNSName = "eni.ip.region.compute.internal"
testTask.ENIs[0].IPV6Addresses = []*ni.IPV6Address{{Address: ipv6}}
cfg, err = testTask.DockerHostConfig(pauseContainer, dockerMap(testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Nil(t, err)
assert.Equal(t, []string{"eni.ip.region.compute.internal:10.0.1.1"}, cfg.ExtraHosts)
// Verify ipv6 setting is enabled.
if runtime.GOOS == "linux" {
require.NotNil(t, cfg.Sysctls)
assert.Equal(t, sysctlValueOff, cfg.Sysctls[disableIPv6SysctlKey])
}
// Verify eni Hostname is added to DockerConfig for pause container
dockerconfig, dockerConfigErr := testTask.DockerConfig(pauseContainer, defaultDockerClientAPIVersion)
assert.Nil(t, dockerConfigErr)
assert.Equal(t, "eni.ip.region.compute.internal", dockerconfig.Hostname)
}
func TestBadDockerHostConfigRawConfig(t *testing.T) {
for _, badHostConfig := range []string{"malformed", `{"Privileged": "wrongType"}`} {
testTask := Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
DockerConfig: apicontainer.DockerConfig{
HostConfig: strptr(badHostConfig),
},
},
},
}
_, err := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(&testTask), defaultDockerClientAPIVersion,
&config.Config{})
assert.Error(t, err)
}
}
func TestDockerConfigRawConfig(t *testing.T) {
rawConfigInput := dockercontainer.Config{
Hostname: "hostname",
Domainname: "domainname",
NetworkDisabled: true,
WorkingDir: "workdir",
User: "user",
}
rawConfig, err := json.Marshal(&rawConfigInput)
if err != nil {
t.Fatal(err)
}
testTask := &Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
DockerConfig: apicontainer.DockerConfig{
Config: strptr(string(rawConfig)),
},
},
},
}
config, configErr := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
if configErr != nil {
t.Fatal(configErr)
}
expectedOutput := rawConfigInput
assertSetStructFieldsEqual(t, expectedOutput, *config)
}
func TestDockerConfigRawConfigNilLabel(t *testing.T) {
rawConfig, err := json.Marshal(&struct{ Labels map[string]string }{nil})
if err != nil {
t.Fatal(err)
}
testTask := &Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
DockerConfig: apicontainer.DockerConfig{
Config: strptr(string(rawConfig)),
},
},
},
}
_, configErr := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
if configErr != nil {
t.Fatal(configErr)
}
}
func TestDockerConfigRawConfigMerging(t *testing.T) {
// Use a struct that will marshal to the actual message we expect; not
// dockercontainer.Config which will include a lot of zero values.
rawConfigInput := struct {
User string `json:"User,omitempty" yaml:"User,omitempty"`
}{
User: "user",
}
rawConfig, err := json.Marshal(&rawConfigInput)
if err != nil {
t.Fatal(err)
}
testTask := &Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
Image: "image",
CPU: 50,
Memory: 1000,
DockerConfig: apicontainer.DockerConfig{
Config: strptr(string(rawConfig)),
},
},
},
}
config, configErr := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
if configErr != nil {
t.Fatal(configErr)
}
expected := dockercontainer.Config{
Image: "image",
User: "user",
}
assertSetStructFieldsEqual(t, expected, *config)
}
func TestBadDockerConfigRawConfig(t *testing.T) {
for _, badConfig := range []string{"malformed", `{"Labels": "wrongType"}`} {
testTask := Task{
Arn: "arn:aws:ecs:us-east-1:012345678910:task/c09f0188-7f87-4b0f-bfc3-16296622b6fe",
Family: "myFamily",
Version: "1",
Containers: []*apicontainer.Container{
{
Name: "c1",
DockerConfig: apicontainer.DockerConfig{
Config: strptr(badConfig),
},
},
},
}
_, err := testTask.DockerConfig(testTask.Containers[0], defaultDockerClientAPIVersion)
if err == nil {
t.Fatal("Expected error, was none for: " + badConfig)
}
}
}
func TestGetCredentialsEndpointWhenCredentialsAreSet(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
credentialsManager := mock_credentials.NewMockManager(ctrl)
credentialsIDInTask := "credsid"
task := Task{
Containers: []*apicontainer.Container{
{
Name: "c1",
Environment: make(map[string]string),
},