Commit e48e584
authored
fix(cdk-lib): multiple submodules use an incorrect namespace for .NET (#36002)
### Issue
53 submodules of `aws-cdk-lib` used the wrong .NET package name.
Example:
```
# ❌ wrong
Amazon.CDK.aws_bedrockagentcore
# ✅ correct
Amazon.CDK.AWS.BedrockAgentCore
```
❌ wrong
<img width="514" height="150" alt="image" src="https://github.com/user-attachments/assets/97477ced-3bf0-4076-abfb-12e46ec55fa9" />
✅ correct
<img width="453" height="123" alt="image" src="https://github.com/user-attachments/assets/8a76b027-faf4-47bd-aeea-7c1d7b4824db" />
Full list of affected submodules:
```
aws-aiops
aws-applicationsignals
aws-apptest
aws-arcregionswitch
aws-arczonalshift
aws-b2bi
aws-backupgateway
aws-bcmdataexports
aws-bedrock
aws-bedrockagentcore
aws-billing
aws-cleanrooms
aws-cleanroomsml
aws-codeconnections
aws-connectcampaignsv2
aws-datazone
aws-deadline
aws-dsql
aws-entityresolution
aws-evs
aws-gameliftstreams
aws-healthimaging
aws-invoicing
aws-launchwizard
aws-mediapackagev2
aws-mpa
aws-neptunegraph
aws-notifications
aws-notificationscontacts
aws-observabilityadmin
aws-odb
aws-osis
aws-paymentcryptography
aws-pcaconnectorad
aws-pcaconnectorscep
aws-pcs
aws-proton
aws-qbusiness
aws-rbin
aws-route53profiles
aws-rtbfabric
aws-s3express
aws-s3tables
aws-s3vectors
aws-securitylake
aws-shield
aws-smsvoice
aws-ssmguiconnect
aws-ssmquicksetup
aws-verifiedpermissions
aws-workspacesinstances
aws-workspacesthinclient
aws-workspacesweb
```
### Reason for this change
The name of submodules is determined by a `.jsiirc.json` inside the submodule directory. If not present, the export name is appended to the name of the parent module. However for most jsii languages this convention is not great: JavaScript export names don't translate well into other ecosystems.
For `aws-cdk-lib` we therefore have added `.jsiirc.json` files into each submodule. For new services, this file is generated when the service is first added. Due to a bug, this generated file was incorrectly adding the key `package` to the `dotnet` target configuration. It should have been `namespace` instead.
Since this was a mistake, we are fixing this now. It means that the package names for the listed 53 submodules are changing for .NET users.
### Description of changes
Update the package names of the listed 53 submodules to use the correct configuration.
Adjusted the order of targets in other `.jsiirc.json` files to be the same as generated ones.
### Describe any new or updated permissions being added
n/a
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 7445176 commit e48e584
File tree
204 files changed
+501
-514
lines changed- packages
- @aws-cdk/aws-eks-v2-alpha
- aws-cdk-lib
- alexa-ask
- aws-accessanalyzer
- aws-acmpca
- aws-aiops
- aws-amazonmq
- aws-amplifyuibuilder
- aws-amplify
- aws-apigatewayv2
- aws-appconfig
- aws-appflow
- aws-appintegrations
- aws-applicationinsights
- aws-applicationsignals
- aws-appmesh
- aws-apprunner
- aws-appstream
- aws-apptest
- aws-aps
- aws-arcregionswitch
- aws-arczonalshift
- aws-auditmanager
- aws-b2bi
- aws-backupgateway
- aws-backup
- aws-bcmdataexports
- aws-bedrockagentcore
- aws-bedrock
- aws-billingconductor
- aws-billing
- aws-cassandra
- aws-ce
- aws-chatbot
- aws-cleanroomsml
- aws-cleanrooms
- aws-codeartifact
- aws-codeconnections
- aws-codeguruprofiler
- aws-codegurureviewer
- aws-codestarconnections
- aws-codestarnotifications
- aws-codestar
- aws-comprehend
- aws-connectcampaignsv2
- aws-connectcampaigns
- aws-connect
- aws-controltower
- aws-cur
- aws-customerprofiles
- aws-databrew
- aws-datasync
- aws-datazone
- aws-deadline
- aws-detective
- aws-devicefarm
- aws-devopsguru
- aws-dlm
- aws-docdbelastic
- aws-docdb
- aws-dsql
- aws-emrcontainers
- aws-emrserverless
- aws-entityresolution
- aws-eventschemas
- aws-evidently
- aws-evs
- aws-finspace
- aws-fis
- aws-fms
- aws-forecast
- aws-frauddetector
- aws-fsx
- aws-gameliftstreams
- aws-globalaccelerator
- aws-grafana
- aws-greengrassv2
- aws-greengrass
- aws-groundstation
- aws-healthimaging
- aws-healthlake
- aws-identitystore
- aws-imagebuilder
- aws-inspectorv2
- aws-internetmonitor
- aws-invoicing
- aws-iotanalytics
- aws-iotcoredeviceadvisor
- aws-iotevents
- aws-iotfleethub
- aws-iotfleetwise
- aws-iotsitewise
- aws-iotthingsgraph
- aws-iottwinmaker
- aws-iotwireless
- aws-ivschat
- aws-ivs
- aws-kafkaconnect
- aws-kendraranking
- aws-kendra
- aws-kinesisanalyticsv2
- aws-kinesisvideo
- aws-lakeformation
- aws-launchwizard
- aws-lex
- aws-licensemanager
- aws-lightsail
- aws-location
- aws-lookoutequipment
- aws-lookoutmetrics
- aws-lookoutvision
- aws-m2
- aws-macie
- aws-managedblockchain
- aws-mediaconnect
- aws-mediaconvert
- aws-medialive
- aws-mediapackagev2
- aws-mediapackage
- aws-mediastore
- aws-mediatailor
- aws-memorydb
- aws-mpa
- aws-msk
- aws-mwaa
- aws-neptunegraph
- aws-neptune
- aws-networkfirewall
- aws-networkmanager
- aws-nimblestudio
- aws-notificationscontacts
- aws-notifications
- aws-oam
- aws-observabilityadmin
- aws-odb
- aws-omics
- aws-opensearchserverless
- aws-opensearchservice
- aws-opsworkscm
- aws-organizations
- aws-osis
- aws-panorama
- aws-paymentcryptography
- aws-pcaconnectorad
- aws-pcaconnectorscep
- aws-pcs
- aws-personalize
- aws-pinpointemail
- aws-pinpoint
- aws-pipes
- aws-proton
- aws-qbusiness
- aws-qldb
- aws-quicksight
- aws-ram
- aws-rbin
- aws-redshiftserverless
- aws-refactorspaces
- aws-rekognition
- aws-resiliencehub
- aws-resourceexplorer2
- aws-resourcegroups
- aws-robomaker
- aws-rolesanywhere
- aws-route53profiles
- aws-route53recoverycontrol
- aws-route53recoveryreadiness
- aws-route53resolver
- aws-rtbfabric
- aws-rum
- aws-s3express
- aws-s3objectlambda
- aws-s3outposts
- aws-s3tables
- aws-s3vectors
- aws-sam
- aws-scheduler
- aws-secretsmanager
- aws-securityhub
- aws-securitylake
- aws-servicecatalogappregistry
- aws-shield
- aws-signer
- aws-simspaceweaver
- aws-smsvoice
- aws-ssmcontacts
- aws-ssmguiconnect
- aws-ssmincidents
- aws-ssmquicksetup
- aws-sso
- aws-supportapp
- aws-synthetics
- aws-systemsmanagersap
- aws-timestream
- aws-transfer
- aws-verifiedpermissions
- aws-voiceid
- aws-vpclattice
- aws-wafv2
- aws-wisdom
- aws-workspacesinstances
- aws-workspacesthinclient
- aws-workspacesweb
- aws-xray
- scripts/submodules
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
204 files changed
+501
-514
lines changedThis file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
0 commit comments