bug fix: change type of KinesisFirehoseRecordMetadata.SubsequenceNumber (#265)

bmoffatt · web-flow · commit 17040d20e347 · 2020-03-02T11:44:21.000Z
diff --git a/events/firehose.go b/events/firehose.go
@@ -39,6 +39,6 @@ type KinesisFirehoseRecordMetadata struct {
 	ShardID                     string                `json:"shardId"`
 	PartitionKey                string                `json:"partitionKey"`
 	SequenceNumber              string                `json:"sequenceNumber"`
-	SubsequenceNumber           string                `json:"subsequenceNumber"`
+	SubsequenceNumber           int64                 `json:"subsequenceNumber"`
 	ApproximateArrivalTimestamp MilliSecondsEpochTime `json:"approximateArrivalTimestamp"`
 }
diff --git a/events/testdata/kinesis-firehose-event.json b/events/testdata/kinesis-firehose-event.json
@@ -13,7 +13,7 @@
          "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",
          "approximateArrivalTimestamp": 1507217624302,
          "sequenceNumber": "49546986683135544286507457936321625675700192471156785154",
-         "subsequenceNumber": "123456"
+         "subsequenceNumber": 123456
        }
      },
      {
@@ -25,7 +25,7 @@
          "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",
          "approximateArrivalTimestamp": 1507217624302,
          "sequenceNumber": "49546986683135544286507457936321625675700192471156785155",
-         "subsequenceNumber": "123457"
+         "subsequenceNumber": 123457
        }
      }
    ]
diff --git a/events/testdata/kinesis-firehose-response.json b/events/testdata/kinesis-firehose-response.json
@@ -11,4 +11,4 @@
        "result": "TRANSFORMED_STATE_DROPPED"
      }
    ]
- }
+ }

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,6 @@ type KinesisFirehoseRecordMetadata struct {`
`39`	`39`	ShardID string `json:"shardId"`
`40`	`40`	PartitionKey string `json:"partitionKey"`
`41`	`41`	SequenceNumber string `json:"sequenceNumber"`
`42`		- SubsequenceNumber string `json:"subsequenceNumber"`
	`42`	+ SubsequenceNumber int64 `json:"subsequenceNumber"`
`43`	`43`	ApproximateArrivalTimestamp MilliSecondsEpochTime `json:"approximateArrivalTimestamp"`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",`
`14`	`14`	`"approximateArrivalTimestamp": 1507217624302,`
`15`	`15`	`"sequenceNumber": "49546986683135544286507457936321625675700192471156785154",`
`16`		`- "subsequenceNumber": "123456"`
	`16`	`+ "subsequenceNumber": 123456`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{`
`@@ -25,7 +25,7 @@`
`25`	`25`	`"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",`
`26`	`26`	`"approximateArrivalTimestamp": 1507217624302,`
`27`	`27`	`"sequenceNumber": "49546986683135544286507457936321625675700192471156785155",`
`28`		`- "subsequenceNumber": "123457"`
	`28`	`+ "subsequenceNumber": 123457`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`	`]`
Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,4 @@`
`11`	`11`	`"result": "TRANSFORMED_STATE_DROPPED"`
`12`	`12`	`}`
`13`	`13`	`]`
`14`		`- }`
	`14`	`+ }`