From 6fceee5990a269416bfdfed657b9ccadd4e23302 Mon Sep 17 00:00:00 2001 From: Ambika Babuji Date: Mon, 7 Apr 2025 23:33:25 -0700 Subject: [PATCH 1/2] Remove ToDo showing up in public facing API reference --- .../amazon/awssdk/core/interceptor/ExecutionAttributes.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java b/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java index e74a7b2b730d..1223bb1e629b 100644 --- a/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java +++ b/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java @@ -162,10 +162,6 @@ public ExecutionAttributes putAttributeIfAbsent(ExecutionAttribute attrib } } - /** - * TODO: We should deprecate this builder - execution attributes are mutable - why do we need a builder? We can just use - * copy() if it's because of {@link #unmodifiableExecutionAttributes(ExecutionAttributes)}. - */ public static final class Builder implements CopyableBuilder { private final Map, Object> executionAttributes = new HashMap<>(32); From 8b97b938ca91fa1dbf2b0ee6404cb308daa4bdae Mon Sep 17 00:00:00 2001 From: Ambika Babuji Date: Wed, 9 Apr 2025 12:23:15 -0700 Subject: [PATCH 2/2] Hide ToDos appearing on public javadoc --- .../amazon/awssdk/core/interceptor/ExecutionAttributes.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java b/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java index 1223bb1e629b..02c03c0a7a06 100644 --- a/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java +++ b/core/sdk-core/src/main/java/software/amazon/awssdk/core/interceptor/ExecutionAttributes.java @@ -162,6 +162,10 @@ public ExecutionAttributes putAttributeIfAbsent(ExecutionAttribute attrib } } + /* + * TODO: We should deprecate this builder - execution attributes are mutable - why do we need a builder? We can just use + * copy() if it's because of {@link #unmodifiableExecutionAttributes(ExecutionAttributes)}. + */ public static final class Builder implements CopyableBuilder { private final Map, Object> executionAttributes = new HashMap<>(32);