ResourceRecordSet object always has a weight property even when Weighted Routing is not enabled

[appleoddity]

Describe the bug

When I call the Get-R53ResourceRecordSet function for a hosted zone it returns a collection of ResourceRecordSet. The value of the weight property is 0 even when there is no Weighted Routing policy applied. In contrast, the documentation indicates that the weight property only applies to weighted resource record sets only. For this reason, it is impossible to determine if the exported resource is supposed to have a weighted routing policy or not.

I am using Powershell 7.

Expected Behavior

Similar to the aws cli, I expect the weight property to be null or undefined when the record does not have a weighted routing policy applied.

Current Behavior

The weight property is 0 even when no weighted routing policy is enabled. A value of 0 has special meaning and this created ambiguity. I assume because the weight property is typed to Int64 .NET is converting a null value to 0.

Reproduction Steps

(Get-R53ResourceRecordSet -HostedZoneId $zone.Id -MaxItem 1000).ResourceRecordSets

Observe the weight property on the exported resource records.

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWS Tools for PowerShell
Version 4.1.547
Copyright 2012-2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.

Amazon Web Services SDK for .NET
Core Runtime Version 3.7.303.4
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.

Targeted .NET Platform

.NET Core

Operating System and version

Ubuntu w/ Powershell 7

[ashishdhingra]

@appleoddity Good morning. Thanks for reporting the issue. AWS Tools for PowerShell uses AWS .NET SDK behind the scenes. Looking at the property definition for Weight, even though it has the Nullable backing field, the getter for this property is using this._weight.GetValueOrDefault() which returns value 0 for null weight.

This is a breaking change for current version of SDK. Also, the property definition in this case is generated from service models. There is a similar issue aws/aws-sdk-net#1721 (comment) in our backlog to be queued for fix in the next version of AWS .NET SDK.

CCing @normj for visibility.

Thanks,
Ashish

[ashishdhingra]

@appleoddity In case you are blocked by this issue, we could do a customization to expose public Is<Property>Set property (e.g. IsWeightSet) in AWS .NET SDK, which you could then use in PowerShell CmdLet response to check if property is set. This is not a clean workaround, however, this is something which could be fully fixed only in next major version of SDK. Please advise.

Thanks,
Ashish

[appleoddity]

Thank you for the fast response and explanation. If it's in the backlog, I will wait until the next release. I went ahead and worked around the problem now, because I didn't actually have any weighted records. The only thing I want to point out is I believe TTL has the same problem. If the record is an alias, there is no TTL value, yet it exports as 0. I'm assuming it is null behind the scenes.

[ashishdhingra]

This has been fixed in AWS Tools for PowerShell version 5.0.0-preview003.

Instructions:

• Install using below commands

  Install-Module -Name AWS.Tools.Common -RequiredVersion 5.0.0-preview003 -AllowPrerelease
  Install-Module -Name AWS.Tools.Route53 -RequiredVersion 5.0.0-preview003 -AllowPrerelease

• You would need to manually import AWS.Tools.Common (refer V5 Development Tracker)

  Import-Module AWS.Tools.Common -RequiredVersion '5.0.0'
  Import-Module AWS.Tools.Route53 -RequiredVersion '5.0.0'

• Executing (Get-R53ResourceRecordSet -HostedZoneId <<Hosted-Zone-Id>>).ResourceRecordSets (specify value for placeholder <<Hosted-Zone-Id>>) returns below output:

  Name                    : testdomain.com.
  Type                    : NS
  SetIdentifier           :
  Weight                  :
  Region                  :
  GeoLocation             :
  Failover                :
  MultiValueAnswer        :
  TTL                     : 172800
  ResourceRecords         : {Amazon.Route53.Model.ResourceRecord, Amazon.Route53.Model.ResourceRecord, 
  Amazon.Route53.Model.ResourceRecord,
                          Amazon.Route53.Model.ResourceRecord}
  AliasTarget             :
  HealthCheckId           :
  TrafficPolicyInstanceId :
  CidrRoutingConfig       :
  GeoProximityLocation    :
  
  Name                    : testdomain.com.
  Type                    : SOA
  SetIdentifier           :
  Weight                  :
  Region                  :
  GeoLocation             :
  Failover                :
  MultiValueAnswer        :
  TTL                     : 900
  ResourceRecords         : {Amazon.Route53.Model.ResourceRecord}
  AliasTarget             :
  HealthCheckId           :
  TrafficPolicyInstanceId :
  CidrRoutingConfig       :
  GeoProximityLocation    :

Closing this issue.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.