Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'version' parameter name not consistant for Read-S3Object when comparing to other similar S3 object cmdlets #369

Closed
1 of 2 tasks
thetasine opened this issue Jan 15, 2025 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. module/powershell-cmdlets p2 This is a standard priority issue queued s Effort estimation: small

Comments

@thetasine
Copy link

Describe the feature

I ran into something that may seem minor, as it affects overall cognitive load when dealing with parameter names when using certain S3 cmdlets.

In this instance, the parameter name for Read-S3Object does not follow the same naming scheme as other similar cmdlets for S3 objects.

Cmdlet Parameter name
Copy-S3Object VersionId
Get-S3ObjectAttribute VersionId
Get-S3ObjectLegalHold VersionId
Get-S3ObjectMetadata VersionId
Get-S3ObjectRetention VersionId
Get-S3ObjectTagSet VersionId
Remove-S3Object VersionId
Read-S3Object Version
Remove-S3ObjectTagSet VersionId
Restore-S3Object VersionId
Write-S3GetObjectResponse VersionId

I may have missed some other examples, but it seems pretty clear for some reason Read-S3Object has a different parameter name.

This always trips me up if I am not thinking about it, as typically I automatically use -VersionId as the parameter name when needing to deal with specific versions when using S3 Object cmdlets.

Use Case

#1 - Consistency is king
#2 - Not having to remember a different parameter name for a single cmdlet when the rest are the same.

Proposed Solution

To avoid a breaking change, can we have a parameter alias of -VersionId added to -Version

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Tools for PowerShell version used

AWS.Tools.S3 4.1.579

PowerShell version used

Name                           Value
----                           -----
PSVersion                      7.4.6
PSEdition                      Core
GitCommitId                    7.4.6
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Operating System and version

Windows 10 and 11

@thetasine thetasine added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 15, 2025
@ashishdhingra ashishdhingra self-assigned this Jan 15, 2025
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. module/powershell-cmdlets p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 15, 2025
@ashishdhingra
Copy link
Contributor

@thetasine Good morning. Thanks for opening the issue. Read-S3Object is a custom hand-written CmdLet and exposes Version. I could also see some inconsistency here where GetObject S3 API call exposes versionId parameter.

However, as you also pointed out, renaming a parameter would be a breaking change. We could use parameter Alias for mitigating this consistency issue. This needs review with the team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added needs-review s Effort estimation: small and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 15, 2025
@thetasine
Copy link
Author

Awesome, I look forward everyone's thoughts on it.

@sankettangade
Copy link
Contributor

sankettangade commented Feb 3, 2025

This issue has been resolved in version 4.1.748. We have added a parameter alias VersionId to address the issue. Please update to the latest version and let us know if you encounter any further issues.

Copy link

github-actions bot commented Feb 3, 2025

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/powershell-cmdlets p2 This is a standard priority issue queued s Effort estimation: small
Projects
None yet
Development

No branches or pull requests

3 participants