Athena-Vertica: Substrait Plan Implementation #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e24575d366336ae7956248861e0c2b18fe818fff.
…formation from Arrow." This reverts commit b240edb.
…haded/metadata files.
…Leo_Changes_feature_QueryPlan_Final_Testing
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
1 similar comment
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
1 similar comment
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Used Latest version of mockito-inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Overview
• This PR implements Substrait plan support for the Athena-Vertica connector, on top of Query Plan implementation(PR - https://github.com/awslabs/aws-athena-query-federation/pull/3041/commits) in the athena-federation-sdk and athena-jdbc connector
• We have also made updates in Athena Federation SDK in the SubstraitSqlUtils in order to handle hasPrecisionTimestamp() in SubstraitSqlUtils type conversion method.
• Unlike other connectors, Vertica executes queries in the MetadataHandler’s doGetSplits method, whereas other connectors perform execution in the RecordHandler. Therefore, the implementation has been added to MetadataHandler.
Bug Fix
• Connection Leakage: Fixed critical connection leakage issue which was hampering testing. The issue occurred in
VerticaMetadataHandler method where database connections were not properly closed, leading to resource exhaustion during testing.
Testing
• One Round of Lambda Testing has been completed, along with backward compatibility testing using the Substrait Implemented Lambda.
Review Guidance
• Please focus review on the three commits mentioned below, which contain our Vertica-specific implementation built on athena-federation-sdk and athena-jdbc Query Plan implementation. Once PR #3041
(https://github.com/awslabs/aws-athena-query-federation/pull/3041/commits) is merged, we can rebase this PR to remove the duplicate changes.
Note
• Most of the changes in this PR are due to Leo's unmerged PR. Please refer to the Vertica project only for the review. We will rebase this PR once Leo's PR is merged: https://github.com/awslabs/aws-athena-query-federation/pull/3041/commits
Existing methods unchanged: All current functionality preserved
Additive enhancement: New method doesn't affect existing code paths
We have made sure that these are backwards compatible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.