Federation SDK: Query plan usage updates and fixes #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
1 similar comment
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
1 similar comment
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Core Federation Infrastructure:
We have made updates in Athena Federation SDK in the SubstraitFunctionParser in order to add additional support for the following:
OR semantics was not preserved for the connector to consume and differentiate between AND and OR functions. Support has been added to maintain tree hierarchy and not return flattened lists.
Support for NOT operations such as NOR (NOT + OR) and NAND (NOT + AND) has been added for connector consumption.
Enhanced federation request handling - Added isRequestFederated() method to FederationRequestHandler to detect federated requests via FAS_TOKEN
Improved secrets management - Extended CachableSecretsManager to support AWS request override configurations for federated authentication
Enhanced metadata/record handlers - Added getRequestOverrideConfig() methods to support federated identity configurations
Additive enhancement: New method doesn't affect existing code paths
We have made sure that these are backwards compatible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.