Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Logging for Queue Attributes Resolver #1149

Open
tomazfernandes opened this issue May 4, 2024 · 1 comment
Open

Improve Logging for Queue Attributes Resolver #1149

tomazfernandes opened this issue May 4, 2024 · 1 comment
Labels
component: sqs SQS integration related issue status: ideal-for-contribution We agree it's nice to have but it is not team priority type: enhancement Smaller enhancement in existing integration

Comments

@tomazfernandes
Copy link
Contributor

Usually the first time Spring Cloud AWS SQS tries to connect to AWS is through QueueAttributesResolver either for resolving attributes or the queue url.

Because of this, any connectivity issue is logged in this context, misleading users to think that the problem is with the default queue creation strategy, when it could really be any other reason.

While the original AWS SDK exception is also already logged, we could look into a better message to help users correctly identify the connection issue.

See #980 (comment)

@tomazfernandes tomazfernandes added component: sqs SQS integration related issue type: enhancement Smaller enhancement in existing integration status: ideal-for-contribution We agree it's nice to have but it is not team priority labels May 4, 2024
@joseiedo
Copy link

joseiedo commented Sep 1, 2024

Hey, Tomaz! I can make a PR for this issue.

What do you think about changing the QueueAttributesResolver.wrapException method by checking if the cause is an instance of software.amazon.awssdk.services.sqs.model.SqsException? If it is, we could add another message, such as:

<current message> + This might be due to connectivity issues with SQS or incorrect configuration.

Or do you think there's a better approach? Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue status: ideal-for-contribution We agree it's nice to have but it is not team priority type: enhancement Smaller enhancement in existing integration
Projects
None yet
Development

No branches or pull requests

2 participants