Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled Conf Var Has No Effect #8

Open
1 of 2 tasks
whipowill opened this issue Jan 17, 2024 · 0 comments
Open
1 of 2 tasks

Enabled Conf Var Has No Effect #8

whipowill opened this issue Jan 17, 2024 · 0 comments

Comments

@whipowill
Copy link

What client do you play on?

enUS

Faction

  • Alliance
  • Horde

Current Behaviour

Just used this mod and it works great, only thing to note is the ModBGItemReward.Enable has no effect.

Expected Blizzlike Behaviour

Expecting it to not work if that setting is off.

Source

No response

Steps to reproduce the problem

  1. Install mod
  2. Forget to enable mod
  3. Set the Marks of Honor to be given
  4. Win a BG
  5. See your reward
  6. Realize you forgot to enable the mod, but it worked anyway

Extra Notes

No response

AC rev. hash/commit

Actually using NPCBots fork atm.

Operating system

Linux

Customizations

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whipowill