Review Test (#118)

* Failure Testing Commit

* chmod +x

* fix path

* add tranvis env

* add nits

* remove circle ci

* change to ruby

* use ruby instead of node

* fix version

* fix version

* addd npm install

* fix eslint

* fix ruby version

* add diff

* add git fetch

* add comments

* use ruby

* use node

* fix lint

Author: azu

.travis.yml

@@ -4,7 +4,7 @@ node_js: "stable"
 after_success:
   - npm run travis:coverage
 after_failure:
-  - sh .travis/review-textlint.sh
+  - ./.travis/review-textlint.sh
 cache:
   directories:
     - node_modules

.travis/review-textlint.sh

@@ -1,19 +1,46 @@
 #!/bin/bash
-if [ "$CI_PULL_REQUEST" == false ] || [ -z "$CI_PULL_REQUEST" ]; then
+
+# Test if pull request
+if [ "$TRAVIS_PULL_REQUEST" = "false" ] || [ -z "$TRAVIS_PULL_REQUEST" ]; then
   echo 'not pull request.'
   exit 0
 fi
 
+# Fetch other branch
+# To avoid ambiguous argument
+# http://stackoverflow.com/questions/37303969/git-fatal-ambiguous-argument-head-unknown-revision-or-path-not-in-the-workin
+if [ "$TRAVIS" == "true" ]; then
+  #resolving `detached HEAD` by attaching HEAD to the `TRAVIS_FROM_BRANCH` branch
+  TRAVIS_FROM_BRANCH="travis_from_branch"
+  git branch $TRAVIS_FROM_BRANCH
+  git checkout $TRAVIS_FROM_BRANCH
+
+  #fetching `TRAVIS_BRANCH` branch
+  git fetch origin $TRAVIS_BRANCH
+  git checkout -qf FETCH_HEAD
+  git branch $TRAVIS_BRANCH
+  git checkout $TRAVIS_BRANCH
+
+  #switch to `TRAVIS_FROM_BRANCH`
+  git checkout $TRAVIS_FROM_BRANCH
+fi
+
+# Install saddler
+# https://github.com/packsaddle/ruby-saddler
+# Need secret env: `GITHUB_ACCESS_TOKEN=xxx`
 gem install --no-document checkstyle_filter-git saddler saddler-reporter-github
 
 # Diff Target Branch
 # diff HEAD...target
 # http://stackoverflow.com/questions/3161204/find-the-parent-branch-of-a-git-branch
 # http://qiita.com/upinetree/items/0b74b08b64442f0a89b9
-diffBranchName=$(git show-branch | grep '*' | grep -v "$(git rev-parse --abbrev-ref HEAD)" | head -1 | awk -F'[]~^[]' '{print $2}')
-# 変更行のみを対象にする
+declare diffBranchName=$(git show-branch | grep '*' | grep -v "$(git rev-parse --abbrev-ref HEAD)" | head -1 | awk -F'[]~^[]' '{print $2}')
+
+# filter files and lint
+echo "${diffBranchName}...HEAD"
+echo "textlint -> review_comments"
 git diff --name-only --diff-filter=ACMR ${diffBranchName} \
-| grep -a '*.md$' \
+| grep -a '.*.md$' \
 | xargs $(npm bin)/textlint -f checkstyle \
 | checkstyle_filter-git diff ${diffBranchName} \
 | saddler report \

package.json

@@ -22,7 +22,7 @@
     "start": "gitbook serve",
     "build": "gitbook build",
     "eslint": "eslint src/**/*.js",
-    "eslint:md": "eslint -c .md.eslintrc --ext .md ja/**/*.md",
+    "eslint:md": "summary-to-path | xargs eslint -c .md.eslintrc --ext .md",
     "textlint": "summary-to-path | xargs textlint --experimental -f pretty-error",
     "test:example": "find ./src -name '*-example.js' | xargs babel-node",
     "test:js": "mocha",

test/prh.yml

@@ -3,6 +3,7 @@ rules:
 # ルールの書き方については https://github.com/vvakame/prh を参照する
 # https://github.com/vvakame/prh/blob/master/misc/prh.yml
 # プロジェクト固有の単語
+  - expected: jQuery
   - expected: ESLint
 
   - expected: Connect