Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop prepending "Maven Central" versions with "v" #10877

Open
cstamas opened this issue Feb 8, 2025 · 4 comments
Open

Stop prepending "Maven Central" versions with "v" #10877

cstamas opened this issue Feb 8, 2025 · 4 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@cstamas
Copy link

cstamas commented Feb 8, 2025

Are you experiencing an issue with...

shields.io

🐞 Description

It is misleading, as there are artifacts that have versions like "v1.2.3" (version starts with letter "v"), so shield would show "vv1.2.3".
Just leave the blue field "as is" (verbatim as version is).

🔗 Link to the badge

https://img.shields.io/maven-central/v/org.apache.maven.resolver/maven-resolver.svg?label=Maven%20Central)](https://search.maven.org/artifact/org.apache.maven.resolver/maven-resolver

💡 Possible Solution

Just drop the prepended "v" from version in blue field.

@cstamas cstamas added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Badge tested using npm run badge https://img.shields.io/maven-central/v/org.apache.maven.resolver/maven-resolver.svg?label=Maven%20Central)](https://search.maven.org/artifact/org.apache.maven.resolver/maven-resolver
Output is available here

@kwin
Copy link

kwin commented Feb 9, 2025

The prefix v is already conditional. See

(prefix ? `${prefix}${version}` : addv(version)) +
and
function addv(version) {
.

@cstamas
Copy link
Author

cstamas commented Feb 9, 2025

Whatever, by by default the version should not be "v" prefixed. This is wrong, and actually the opposite that should be: If I want "v" prefix, I'd need to turn something ON, and not turn OFF to lose some prefix being automatically added.

@michael-o
Copy link

Whatever, by by default the version should not be "v" prefixed. This is wrong, and actually the opposite that should be: If I want "v" prefix, I'd need to turn something ON, and not turn OFF to lose some prefix being automatically added.

Agree, it has not benefit or purpose because it constantly repeats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

3 participants