never delete refresh token when refreshing

balland · balland · commit 7714233a2c9d · 2020-09-22T08:55:36.000+02:00
Otherwise this may cause any error or loss of connectivity leading to refresh token deletion. There is a pending PR on the main repo p2#281 Related to sensational/popscan-android#977
diff --git a/Sources/Flows/OAuth2.swift b/Sources/Flows/OAuth2.swift
@@ -374,7 +374,6 @@ open class OAuth2: OAuth2Base {
 					let data = try response.responseData()
 					let json = try self.parseRefreshTokenResponseData(data)
 					if response.response.statusCode >= 400 {
-						self.clientConfig.refreshToken = nil
 						throw OAuth2Error.generic("Failed with status \(response.response.statusCode)")
 					}
 					self.logger?.debug("OAuth2", msg: "Did use refresh token for access token [\(nil != self.clientConfig.accessToken)]")

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,6 @@ open class OAuth2: OAuth2Base {`
`374`	`374`	`let data = try response.responseData()`
`375`	`375`	`let json = try self.parseRefreshTokenResponseData(data)`
`376`	`376`	`if response.response.statusCode >= 400 {`
`377`		`- self.clientConfig.refreshToken = nil`
`378`	`377`	`throw OAuth2Error.generic("Failed with status \(response.response.statusCode)")`
`379`	`378`	`}`
`380`	`379`	`self.logger?.debug("OAuth2", msg: "Did use refresh token for access token [\(nil != self.clientConfig.accessToken)]")`