Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize repository rule naming for 3rd party packages. #72

Open
sluongng opened this issue Jun 9, 2023 · 0 comments
Open

Standardize repository rule naming for 3rd party packages. #72

sluongng opened this issue Jun 9, 2023 · 0 comments

Comments

@sluongng
Copy link

sluongng commented Jun 9, 2023

I recently observe in https://github.com/aherrmann/rules_zig/ that the toolchain is managed via a rule called zig_repository, which follow the template convention of mylang_repository.

However, what I am used to in Go is go_repository is used to manage 3rd party dependency import. Toolchain in Go is managed via go_{download,local,host}_sdk and go_register_toolchains rules instead.

So I would suggest renaming mylang_repository to mylang_sdk and mylang_register_toolchains while reserving mylang_repository for respective language's 3rd party import. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant