Respect XDG directory settings on macOS #25205
Conversation
github-actions
bot
added
team-Rules-CPP
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
(For general background on XDG_* env variables on mac, see e.g. https://stackoverflow.com/questions/3373948/equivalents-of-xdg-config-home-and-xdg-data-home-on-mac-os-x) |
tetromino
added
team-CLI
|
Ok, I've done some git archaeology. Already in 2016 (commit f107deb) @lberki removed the Unix domain socket file on both linux and mac, and after a rollback and a fix, the change stuck. In the internal review for f107deb a reviewer noted that this change meant Bazel can switch back from /var/tmp to ${HOME}/Library/Caches (the "normal" cache directory on mac), however this was not followed up upon and not done. Currently on a mac, My conclusion is that this PR is mostly ok, but we should follow up by also moving to the expected cache dir on mac. |
There was a problem hiding this comment.
Please add a comment explaining.
Something like:
string GetCacheDir() {
// See https://stackoverflow.com/questions/3373948/equivalents-of-xdg-config-home-and-xdg-data-home-on-mac-os-x
// for general background. On macOS, the normal cache directory is
// ${HOME}/Library/Caches; Bazel historically instead used /var/tmp due to
// path length limits on Unix domain sockets. (Those limits are no longer
// relevant since we no longer create Unix domain sockets under output_base.)
// However, it is still useful to respect ${XDG_CACHE_HOME} because it allows
// users to easily override the cache directory and is respected by many
// Linux-derived tools.
...
|
@tetromino Thank you for the feedback – I believe I've incorporated what you've asked for. |
|
I don't think these Windows failures are due to my changes. |
Fixes #25167
Copies much of the logic over from
blaze_util_linux.ccand its tests into the Darwin space to implement the feature request.