fix: rules_cc is not a dev_dependency #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the tools/file_concat program is written in C++ and exposed to users of proto_descriptor_set, we depend on rules_cc at runtime.
|
Ping @comius |
comius
reviewed
May 2, 2024
|
ping @comius |
|
ping @alexeagle |
|
Removed the comment - good to merge now? |
|
i missed this one and submitted with lockfile and workspace changes too #215, doesn't matter which is merged but it would be nice to see 1 land |
keith
added a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
May 28, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
|
@meteorcloudy could you merge please? I'm sad to start the precedent of BCR diverging from the repo it's published from, only because the former has active maintainers with commit access |
comius
approved these changes
May 29, 2024
|
Closing as a duplicate of #215 |
fmeum
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
May 29, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
aiuto
pushed a commit
to aiuto/bazel-central-registry
that referenced
this pull request
Jun 3, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
zaucy
pushed a commit
to zaucy/bazel-central-registry
that referenced
this pull request
Jun 14, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tools/file_concat program is written in C++ and exposed to users of proto_descriptor_set, we depend on rules_cc at runtime.
Fixes #203