You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Alternative proto rulesets (namely stackb) support not generating Java byte code for proto_library.deps() via a transitive attribute.
Today, java_proto_library generates bytecode for both a proto_library's srcs and deps attributes. Generating bytecode for deps can lead to duplicate class exceptions if the consumer also tries to generate and pack the resulting class files into a JAR.
Would you consider supporting a transitive attribute for java_proto_library?
The text was updated successfully, but these errors were encountered:
AFAICT, this should be possible today if you define your own proto_lang_toolchain and adding the .proto files that are packed into the .jar to blacklisted_protos.
Generating code for transitive (non-blacklisted) protos is by design so you don't have to explicitly mirror the proto-graph for every language, so I think it's unlikely that a transitive attribute will be supported.
comius
added
the
P4
This is either out of scope or we don't have bandwidth to review a PR. (No assignee)
label
Feb 10, 2022
Alternative proto rulesets (namely stackb) support not generating Java byte code for
proto_library.deps()
via atransitive
attribute.Today,
java_proto_library
generates bytecode for both aproto_library
'ssrcs
anddeps
attributes. Generating bytecode fordeps
can lead to duplicate class exceptions if the consumer also tries to generate and pack the resulting class files into a JAR.Would you consider supporting a transitive attribute for
java_proto_library
?The text was updated successfully, but these errors were encountered: