Replace Node 12 with Node 18

[creisle]

Tasks

• Drop support for node 12 now that it is out of LTS
• Add support for Node 18 not that it has been released https://nodejs.org/en/blog/announcements/v18-release-announce/

Checks

• Test on centos07
• Test on ubuntu (github build)
• Test build with docker container

[mathieulemieux]

On CentOS v7.6.1810 (phage.bcgsc.ca), I checkout https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36 from develop, rebuild the node_modules with node 18.3.0, uninstall commitizen and cz-conventional-changelog dependencies follow by an npm audit fix as we did with #40. All GH checks passed.

@creisle, should I add node 18 here ?

pori_graphkb_api/.github/workflows/npm-test.yml

Line 12 in 10c6864

node: [12, 14, 16]

[mathieulemieux]

Ok, I changed node 12 for 18 in the workflows, but both orientdb 3.0 and 3.1 were failing so I rolled back.
Put the changes in another branch to show errors in log : https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36b

[mathieulemieux]

The source code of orientjs package didn't had a commit since 2y on develop and 4y on master. Tests performed on npm include node v10 and v12 only. I wonder if moving to node 18 now is too soon.

[creisle]

Are the errors you are seeing related to orientjs? can you copy/paste the relevant error messages to this ticket

[creisle]

On CentOS v7.6.1810 (phage.bcgsc.ca), I checkout https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36 from develop, rebuild the node_modules with node 18.3.0, uninstall commitizen and cz-conventional-changelog dependencies follow by an npm audit fix as we did with #40. All GH checks passed.

@creisle, should I add node 18 here ?

pori_graphkb_api/.github/workflows/npm-test.yml

Line 12 in 10c6864

node: [12, 14, 16]

yes, and remove 12

[mathieulemieux]

Here is a branch with tests for Node v.18 : https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36b.

Here is the logs: https://github.com/bcgsc/pori_graphkb_api/runs/6888639803?check_suite_focus=true

File here: 5_orientdb-3.0 node-18.txt

[mathieulemieux]

When "npm start" the api with Node.js v18+, we inevitably encounter this error:

• "TypeError: Cannot set property closed of # which has only a getter"

Here is what it's going on:

• The orientjs module rely on the "Readable" object of the "stream" native Node.js library.
• Since Node.js v18.0.0, this object have only a getter method for the closed boolean property; it lost its setter (see https://github.com/nodejs/node/blob/v18.0.0/lib/internal/streams/readable.js#L1243).
• When you can edit the module who interact with the Readable object, this is an easy fix, e.g. streamich/memfs@d1823e1.
• Unfortunately, the orientjs package development seems to be stalled for a while now: https://github.com/orientechnologies/orientjs
• When hard-coding the fix myself in the orientjs library, everything works when starting the api under Node.js v18.