Skip to content

Commit 76558d5

Browse files
fix: bugfix undefined prop (#1)
if you only want queryParams but not route params, this hoc sends you a prop with key-value undefined: undefined.
1 parent be0c7e4 commit 76558d5

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/index.tsx

+8-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import setDisplayName from 'recompose/setDisplayName'
66
import wrapDisplayName from 'recompose/wrapDisplayName'
77

88
function extractParams(names, params) {
9-
if (!names || !params) return
10-
const newProps = {params}
9+
if (!names || !params || names.length === 0) return
10+
const newProps = {}
1111

1212
for (const name of names) {
1313
newProps[name] = params[name]
@@ -56,8 +56,12 @@ export const withParams = (
5656
) => WrappedComponent => {
5757
const displayName = wrapDisplayName(WrappedComponent, 'withParams')
5858

59-
paramsNames = Array.isArray(paramsNames) ? paramsNames : [paramsNames]
60-
queryParams = Array.isArray(queryParams) ? queryParams : [queryParams]
59+
paramsNames = Array.isArray(paramsNames)
60+
? paramsNames
61+
: paramsNames ? [paramsNames] : []
62+
queryParams = Array.isArray(queryParams)
63+
? queryParams
64+
: queryParams ? [queryParams] : []
6165

6266
if (state) {
6367
state = Array.isArray(state) ? state : [state]

0 commit comments

Comments
 (0)