From 5b28af4401d49716c80b1c47520b56ae23778311 Mon Sep 17 00:00:00 2001
From: bebehr <behr.benny@gmail.com>
Date: Thu, 20 Feb 2025 22:51:14 +0100
Subject: [PATCH] fix(spec-char-escape): remove ampersand from spec-char-escape

Ampersand is acceptable in HTML text, e. g. see: W3C validator

fix #1382
---
 docs/user-guide/rules/spec-char-escape.md | 4 +++-
 src/core/rules/spec-char-escape.ts        | 3 +--
 test/rules/spec-char-escape.spec.js       | 9 +++------
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/docs/user-guide/rules/spec-char-escape.md b/docs/user-guide/rules/spec-char-escape.md
index b94658651..67ed84bcb 100644
--- a/docs/user-guide/rules/spec-char-escape.md
+++ b/docs/user-guide/rules/spec-char-escape.md
@@ -12,11 +12,13 @@ Level: `error`
 1. true: enable rule
 2. false: disable rule
 
-The following pattern are **not** considered violations:
+The following patterns are **not** considered violations:
 
 <!-- prettier-ignore -->
 ```html
 <span>aaa&gt;bbb&lt;ccc</span>
+<span>Steinway &amp; Sons, Q&amp;A</span>
+<span>Steinway & Sons, Q&A</span>
 ```
 
 The following pattern is considered violation:
diff --git a/src/core/rules/spec-char-escape.ts b/src/core/rules/spec-char-escape.ts
index de1601662..c436af9f8 100644
--- a/src/core/rules/spec-char-escape.ts
+++ b/src/core/rules/spec-char-escape.ts
@@ -6,8 +6,7 @@ export default {
   init(parser, reporter) {
     parser.addListener('text', (event) => {
       const raw = event.raw
-      // TODO: improve use-cases for &
-      const reSpecChar = /([<>])|( \& )/g
+      const reSpecChar = /([<>])/g
       let match
 
       while ((match = reSpecChar.exec(raw))) {
diff --git a/test/rules/spec-char-escape.spec.js b/test/rules/spec-char-escape.spec.js
index b1f883537..cd8c5f674 100644
--- a/test/rules/spec-char-escape.spec.js
+++ b/test/rules/spec-char-escape.spec.js
@@ -21,13 +21,10 @@ describe(`Rules: ${ruleId}`, () => {
     expect(messages[2].col).toBe(4)
   })
 
-  it('Special characters: & should result in an error', () => {
-    const code = '<p>Steinway & Sons</p>'
+  it('Special characters: normal & should not result in an error', () => {
+    const code = '<p>Steinway & Sons Q&A</p>'
     const messages = HTMLHint.verify(code, ruleOptions)
-    expect(messages.length).toBe(1)
-    expect(messages[0].rule.id).toBe(ruleId)
-    expect(messages[0].line).toBe(1)
-    expect(messages[0].col).toBe(12)
+    expect(messages.length).toBe(0)
   })
 
   it('Normal text should not result in an error', () => {