-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confuse should be able to return bytestrings for Filename() #51
Comments
Can you elaborate a little bit? Where exactly is this needed, and why (vs. just wrapping the lookup with |
If you do: config['foo']['file'] = some_bytestring # like we do in beet in various places (likely in the tests) and then attempt file = config['foo']['file'].as_filename() then it'll blow up right here https://github.com/beetbox/beets/blob/master/beets/util/confit.py#L1350 |
Got it. In those cases, it's probably best to change the tests—because, in the real world, those values with be Unicode strings when they come from config files. (And we'd like to test conditions that resemble the real world.) |
ok, so that's back to the age old question of converting bytestring filenames to utf-8. come up with a name for the utility function yet? :) |
Right; good point. Let's call it |
No description provided.
The text was updated successfully, but these errors were encountered: