Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about default sandbox settings #5

Open
simbados opened this issue Jan 4, 2022 · 2 comments
Open

Question about default sandbox settings #5

simbados opened this issue Jan 4, 2022 · 2 comments

Comments

@simbados
Copy link

simbados commented Jan 4, 2022

Hi!

Thanks for this awesome project, really appreciate the effort to make the node ecosystem more secure.
I have one question:
Why does the default sandbox need permission to read master.passwd and passwd? (See lines 31 and 32)

(literal "/private/etc/master.passwd")

@berstend
Copy link
Owner

berstend commented Jan 9, 2022

@simbados thanks for the feedback :)
In my testing vanilla Node.js was accessing these files, though blocking them seemed to not break anything. I've whitelisted them for the time being until I've had the chance to dig deeper into this and understand the possible implications of blocking access to these specific files.

(If someone knows more specifically why node is accessing them feel free to chime in)

@simbados
Copy link
Author

Thanks for the answer!
I might have two more questions:

  1. I would really love to see that this repo gets more traction. What do you think about funding, for example a gitcoin grant?
  2. Do you think this concept is portable to other package managers, e.g. pip or cargo?
    I think these ecosystems suffer from the same problems (maybe not that extensive, but restricting permission is always a good default option). Not sure if this is way out of scope or if this could be introduced at a later time.

Have a good week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants