Enhance Behat tests.

Author: lucaboesch

.github/workflows/moodle-ci.yml

@@ -8,7 +8,7 @@ jobs:
 
     services:
       postgres:
-        image: postgres:14
+        image: postgres:15
         env:
           POSTGRES_USER: 'postgres'
           POSTGRES_HOST_AUTH_METHOD: 'trust'
@@ -30,6 +30,30 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - php: 8.4
+            moodle-branch: MOODLE_501_STABLE
+            database: pgsql
+            plugin-ci: 4
+          - php: 8.4
+            moodle-branch: MOODLE_501_STABLE
+            database: mariadb
+            plugin-ci: 4
+          - php: 8.3
+            moodle-branch: MOODLE_501_STABLE
+            database: pgsql
+            plugin-ci: 4
+          - php: 8.3
+            moodle-branch: MOODLE_501_STABLE
+            database: mariadb
+            plugin-ci: 4
+          - php: 8.2
+            moodle-branch: MOODLE_501_STABLE
+            database: pgsql
+            plugin-ci: 4
+          - php: 8.2
+            moodle-branch: MOODLE_501_STABLE
+            database: mariadb
+            plugin-ci: 4
           - php: 8.4
             moodle-branch: MOODLE_500_STABLE
             database: pgsql

backup/moodle2/backup_qtype_fileresponse_plugin.class.php

@@ -22,7 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class backup_qtype_fileresponse_plugin extends backup_qtype_plugin {
-
     /**
      * Returns the qtype information to attach to question element
      */
@@ -47,8 +46,10 @@ protected function define_question_plugin_structure() {
         $pluginwrapper->add_child($fileresponse);
 
         // Set source to populate the data.
-        $fileresponse->set_source_table('qtype_fileresponse_options',
-                ['questionid' => backup::VAR_PARENTID]);
+        $fileresponse->set_source_table(
+            'qtype_fileresponse_options',
+            ['questionid' => backup::VAR_PARENTID]
+        );
 
         // Don't need to annotate ids nor files.
 

backup/moodle2/restore_qtype_fileresponse_plugin.class.php

@@ -23,7 +23,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class restore_qtype_fileresponse_plugin extends restore_qtype_plugin {
-
     /**
      * Returns the paths to be handled by the plugin at question level
      */
@@ -54,8 +53,10 @@ public function process_fileresponse($data) {
         }
 
         // Detect if the question is created or mapped.
-        $questioncreated = $this->get_mappingid('question_created',
-                $this->get_old_parentid('question')) ? true : false;
+        $questioncreated = $this->get_mappingid(
+            'question_created',
+            $this->get_old_parentid('question')
+        ) ? true : false;
 
         // If the question has been created by restore, we need to create its
         // qtype_fileresponse too.

classes/privacy/provider.php

@@ -31,7 +31,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements \core_privacy\local\metadata\null_provider {
-
     /**
      * Get the language string identifier with the component's language
      * file to explain why this plugin stores no data.

db/upgrade.php

@@ -32,7 +32,6 @@ function xmldb_qtype_fileresponse_upgrade($oldversion) {
     $dbman = $DB->get_manager();
 
     if ($oldversion < 2019120200) {
-
         // Add "filetypeslist" column to the question type options to save the allowed file types.
         $table = new xmldb_table('qtype_fileresponse_options');
         $field = new xmldb_field('filetypeslist', XMLDB_TYPE_TEXT, null, null, null, null, null, 'responsetemplateformat');

edit_fileresponse_form.php

@@ -32,15 +32,17 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class qtype_fileresponse_edit_form extends question_edit_form {
-
-
     protected function definition_inner($mform) {
         $qtype = question_bank::get_qtype('fileresponse');
 
         /* Display the ?forcedownload=1 advice. */
-        $mform->addElement('static', 'advice', get_string('advice', 'qtype_fileresponse'),
+        $mform->addElement(
+            'static',
+            'advice',
+            get_string('advice', 'qtype_fileresponse'),
             '<div style="width:496px;">' . get_string('questiontextforcedownload', 'qtype_fileresponse') .
-            '</div>');
+            '</div>',
+        );
 
         /* fileresponse only accepts 'formatplain' as format */
         $mform->setDefault('responseformat', 'plain');
@@ -52,13 +54,21 @@ protected function definition_inner($mform) {
 
         /* Response required element removed from qtype_essay. */
 
-        $mform->addElement('select', 'responsefieldlines',
-            get_string('responsefieldlines', 'qtype_fileresponse'), $qtype->response_sizes());
+        $mform->addElement(
+            'select',
+            'responsefieldlines',
+            get_string('responsefieldlines', 'qtype_fileresponse'),
+            $qtype->response_sizes()
+        );
         $mform->setDefault('responsefieldlines', 15);
 
         /* Fileresponse has to have at least one file required */
-        $mform->addElement('select', 'attachments',
-            get_string('amountofexpectedfiles', 'qtype_fileresponse'), $qtype->attachment_options());
+        $mform->addElement(
+            'select',
+            'attachments',
+            get_string('amountofexpectedfiles', 'qtype_fileresponse'),
+            $qtype->attachment_options(),
+        );
         $mform->setDefault('attachments', 1);
 
         /* Attachment required element removed from qtype_essay. */
@@ -68,21 +78,34 @@ protected function definition_inner($mform) {
         $mform->disabledIf('filetypeslist', 'attachments', 'eq', 0);
 
         /* The element to allow or disallow repositories. */
-        $mform->addElement('select', 'forcedownload',
-            get_string('forcedownload', 'qtype_fileresponse'), $qtype->forcedownload_options());
+        $mform->addElement(
+            'select',
+            'forcedownload',
+            get_string('forcedownload', 'qtype_fileresponse'),
+            $qtype->forcedownload_options(),
+        );
         $mform->setDefault('forcedownload', 0);
 
         /* The element to allow or disallow repositories. */
-        $mform->addElement('select', 'allowpickerplugins',
-            get_string('allowpickerplugins', 'qtype_fileresponse'), $qtype->allowpickerplugins_options());
+        $mform->addElement(
+            'select',
+            'allowpickerplugins',
+            get_string('allowpickerplugins', 'qtype_fileresponse'),
+            $qtype->allowpickerplugins_options()
+        );
         $mform->setDefault('allowpickerplugins', 0);
 
         /* Response template element removed from qtype_essay. */
 
         $mform->addElement('header', 'graderinfoheader', get_string('graderinfoheader', 'qtype_fileresponse'));
         $mform->setExpanded('graderinfoheader');
-        $mform->addElement('editor', 'graderinfo', get_string('graderinfo', 'qtype_fileresponse'),
-            array('rows' => 10), $this->editoroptions);
+        $mform->addElement(
+            'editor',
+            'graderinfo',
+            get_string('graderinfo', 'qtype_fileresponse'),
+            ['rows' => 10],
+            $this->editoroptions,
+        );
     }
 
     protected function data_preprocessing($question) {
@@ -103,13 +126,13 @@ protected function data_preprocessing($question) {
         $draftid = file_get_submitted_draft_itemid('graderinfo');
         $question->graderinfo = array();
         $question->graderinfo['text'] = file_prepare_draft_area(
-            $draftid,           // Draftid.
+            $draftid, // Draftid.
             $this->context->id, // Context.
-            'qtype_fileresponse',      // Component.
-            'graderinfo',       // Filarea.
+            'qtype_fileresponse', // Component.
+            'graderinfo', // Filearea.
             !empty($question->id) ? (int) $question->id : null, // Itemid.
             $this->fileoptions, // Options.
-            $question->options->graderinfo // Text.
+            $question->options->graderinfo, // Text.
         );
         $question->graderinfo['format'] = $question->options->graderinfoformat;
         $question->graderinfo['itemid'] = $draftid;
@@ -128,8 +151,10 @@ public function validation($fromform, $files) {
 
         // Don't allow the teacher to require more attachments than they allow; as this would
         // create a condition that it's impossible for the student to meet.
-        if ((isset($fromform['attachmentsrequired'])) &&
-            ($fromform['attachments'] != -1 && $fromform['attachments'] < $fromform['attachmentsrequired'])) {
+        if (
+            (isset($fromform['attachmentsrequired'])) &&
+            ($fromform['attachments'] != -1 && $fromform['attachments'] < $fromform['attachmentsrequired'])
+        ) {
                 $errors['attachmentsrequired']  = get_string('mustrequirefewer', 'qtype_fileresponse');
         }