Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request API getCountryByPhoneCode #71

Open
penhauer opened this issue Dec 20, 2020 · 4 comments · May be fixed by #81
Open

request API getCountryByPhoneCode #71

penhauer opened this issue Dec 20, 2020 · 4 comments · May be fixed by #81

Comments

@penhauer
Copy link

Mostly we need phone code of some country but sometimes the reverse is needed so i thought this would be an appropriate feature request.

@kianomoomi kianomoomi linked a pull request Feb 3, 2022 that will close this issue
@CodeVibranium
Copy link

CodeVibranium commented Jun 14, 2023

Hey @penhauer , I would like to work on this, can you assign it to me.
And can also provide me with these details

  1. Shall the API return all the countries list where the phone code is an EXACT match.
  2. If not exact match what should the API return and if no country is found what should be the return value .
  3. Shall i omit the + from API input as it is common

@CodeVibranium
Copy link

@penhauer , Created a PR, please check it out.

@penhauer
Copy link
Author

penhauer commented Jun 16, 2023

Hey @CodeVibranium, Feel free to apply your desired changes as i'm not the repo owner and needless to say i cannot merge your code. Contact the owner if you like to do a PR. But anyway, i appreciate your efforts.

@CodeVibranium
Copy link

CodeVibranium commented Jun 16, 2023

Hey @CodeVibranium, Feel free to apply your desired changes as i'm not the repo owner and needless to say i cannot merge your code. Contact the owner if you like to do a PR. But anyway, i appreciate your efforts.

@penhauer, thankyou.
@bhatvikrant, Can you look at this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants